You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/05/31 10:36:15 UTC

[GitHub] [brooklyn-ui] ahgittin commented on a change in pull request #206: Allow downstream to configure edit.dsl controller

ahgittin commented on a change in pull request #206:
URL: https://github.com/apache/brooklyn-ui/pull/206#discussion_r642392047



##########
File path: ui-modules/blueprint-composer/app/views/main/graphical/edit/dsl/edit.dsl.controller.js
##########
@@ -131,27 +127,31 @@ export const graphicalEditDslState = {
         index: {
             value: '',
             squash: true
-        }
+        },
+        isConfig: true // This flag identifies whether DSL edit is for configuration or something else. Configuration is a default.

Review comment:
       would be nicer to call this something like `subsection` which might take values `config`, `location`, etc




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org