You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/03 03:04:28 UTC

[GitHub] [skywalking-infra-e2e] hanahmily commented on pull request #64: improve doc

hanahmily commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958615827


   > > The health checker was introduced by [kubernetes-sigs/controller-runtime#1588](https://github.com/kubernetes-sigs/controller-runtime/pull/1588) which is not part of swck's dependencies though.
   > 
   > If this exists, then FAQ should not be added. Instead, this is a potential feature for SWCK. Please confirm.
   
   Yep, to ensure webhook server before applying CRs is the e2e framework users' job. In another word, it's the behavior of kubernetes. If the e2e framework declared it's built on it, the user should accept this result. Based on that, this tip should be submitted to the kubernetes communication, not here 😄 . 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org