[GitHub] [cassandra] dcapwell commented on pull request #2031: CASSANDRA-18077: Add SpotBugs to the build

[GitBox <gi...@apache.org>]

dcapwell commented on PR #2031:
URL: https://github.com/apache/cassandra/pull/2031#issuecomment-1331398159

   > Can we separate commits between introducing the linter, to code fixes for the linter?
   
   What is the intent?  I don't plan do merge with multiple commits, so is this to help review?
   
   > Can we bring over checkstyle and other linter stuff from build.xml to .build/build-linter.xml ?
   
   I could, I just felt this patch was large already...
   
   > Unrelated, what's your thoughts about the .build/[cassandra-build-deps-template](https://issues.apache.org/jira/browse/CASSANDRA-build-deps-template).xml filenames? (Is template confusing and should they be called something like .build/cassandra-build-deps-unfiltered.xml instead?)
   
   I find `template` is better than `unfiltered` as `template` is more what this is... a file we modify using special keywords to generate our desired output...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org