You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2018/08/11 23:07:43 UTC
[arrow] branch master updated: ARROW-3046: [GLib] Use rubyish method
This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new ed3306b ARROW-3046: [GLib] Use rubyish method
ed3306b is described below
commit ed3306b589d825dc63e2517ab3ebc23edecb7cf1
Author: yosuke shiro <ys...@gmail.com>
AuthorDate: Sun Aug 12 08:06:55 2018 +0900
ARROW-3046: [GLib] Use rubyish method
Because `field_indexes = [1, 3]` is rubyish than `set_field_indexes[1, 3]`.
Author: yosuke shiro <ys...@gmail.com>
Closes #2426 from shiro615/use-rubyish-method and squashes the following commits:
d1e809a6 <yosuke shiro> Use rubyish method
---
c_glib/test/test-orc-file-reader.rb | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/c_glib/test/test-orc-file-reader.rb b/c_glib/test/test-orc-file-reader.rb
index 5f65520..9d1d1b6 100644
--- a/c_glib/test/test-orc-file-reader.rb
+++ b/c_glib/test/test-orc-file-reader.rb
@@ -45,8 +45,9 @@ map: list<item: struct<key: string, value: struct<int1: int32, string1: string>>
def test_field_indexes
require_gi(1, 42, 0)
+ require_gi_bindings(3, 2, 6)
assert_nil(@reader.field_indexes)
- @reader.set_field_indexes([1, 3])
+ @reader.field_indexes = [1, 3]
assert_equal([1, 3], @reader.field_indexes)
end
@@ -186,7 +187,8 @@ map: list<item: struct<key: string, value: struct<int1: int32, string1: string>>
end
test("select fields") do
- @reader.set_field_indexes([1, 3])
+ require_gi_bindings(3, 2, 6)
+ @reader.field_indexes = [1, 3]
table = @reader.read_stripes
dump = table.n_columns.times.collect do |i|
column = table.get_column(i)
@@ -332,7 +334,8 @@ map: list<item: struct<key: string, value: struct<int1: int32, string1: string>>
end
test("select fields") do
- @reader.set_field_indexes([1, 3])
+ require_gi_bindings(3, 2, 6)
+ @reader.field_indexes = [1, 3]
record_batch = @reader.read_stripe(0)
dump = record_batch.n_columns.times.collect do |i|
[