[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5299: fix: add yield point to `RepartitionExec`

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5299:
URL: https://github.com/apache/arrow-datafusion/pull/5299#discussion_r1108882219


##########
datafusion/core/src/physical_plan/repartition/mod.rs:
##########
@@ -532,6 +532,10 @@ impl RepartitionExec {
                 }
                 timer.done();
             }
+
+            // If the input stream is endless, we may spin forever and never yield back to tokio. Hence let us yield.

Review Comment:
   👍 



##########
datafusion/core/tests/repartition_exec_blocks.rs:
##########
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   what do you think about naming this test something more general like `repartiton.rs`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org