Re: svn commit: r750799 - in /ofbiz/trunk/framework: common/data/CommonTypeData.xml webtools/webapp/webtools/WEB-INF/web.xml

[David E Jones <da...@hotwaxmedia.com>]

Yes, sounds good.

-David


On Mar 6, 2009, at 2:07 PM, Bruno Busco wrote:

> I think I have copy and paste it in a recent commit when WebSiteId
> setting has been added to all web applications.
> I would suggest to replace all with the simpler description:
>    <description>A unique ID used to look up the WebSite entity</ 
> description>
>
>
> If you are OK I will update it.
>
> -Bruno
>
> 2009/3/6 David E Jones <da...@hotwaxmedia.com>:
>>
>> I looks like it comes from the original one in the ecommerce  
>> web.xml file.
>>
>> -David
>>
>>
>> On Mar 6, 2009, at 9:21 AM, Jacques Le Roux wrote:
>>
>>> Mmm, it seems that there is much more than that : 29 occurrences  
>>> of the
>>> same string in OFBiz, not sure all are correct...
>>> <description>A unique ID used to look up the WebSite entity to get
>>> information about catalogs, etc.</description>
>>>
>>> I will see... Any help appreciated of course...
>>>
>>> Jacques
>>>
>>> From: "Ashish Vijaywargiya" <vi...@gmail.com>
>>>>
>>>> Hello Jacques,
>>>>
>>>>>> <description>A unique ID used to look up the WebSite entity to  
>>>>>> get
>>>>>> information about catalogs, etc.</description>
>>>>
>>>> Please change "about catalogs" to "about webtools".
>>>> Thanks !
>>>>
>>>> --
>>>> Ashish Vijaywargiya
>>>>
>>>> On Fri, Mar 6, 2009 at 1:23 PM,  <jl...@apache.org> wrote:
>>>>>
>>>>> Author: jleroux
>>>>> Date: Fri Mar 6 07:53:21 2009
>>>>> New Revision: 750799
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=750799&view=rev
>>>>> Log:
>>>>> A patch from Bruno Busco "Now the VisualTheme is changeable from  
>>>>> the
>>>>> Webtools also." (https://issues.apache.org/jira/browse/ 
>>>>> OFBIZ-2229) -
>>>>> OFBIZ-2229
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>> ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>>>>>
>>>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=750799&r1=750798&r2=750799&view=diff
>>>>>
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> ==================================================================
>>>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml  
>>>>> (original)
>>>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Fri Mar 6
>>>>> 07:53:21 2009
>>>>> @@ -130,6 +130,8 @@
>>>>> <VisualThemeResource visualThemeId="DEFAULT"
>>>>> resourceTypeEnumId="VT_MSG_TMPLT_LOC"
>>>>> resourceValue="component://common/webcommon/includes/messages.ftl"
>>>>> sequenceId="01"/>
>>>>> <VisualThemeResource visualThemeId="DEFAULT"
>>>>> resourceTypeEnumId="VT_SCREENSHOT"
>>>>> resourceValue="/images/default-screenshot.gif" sequenceId="01"/>
>>>>>
>>>>> + <WebSite webSiteId="WEBTOOLS" siteName="Web Tools"
>>>>> visualThemeSetId="BACKOFFICE" />
>>>>> +
>>>>> <!-- Uom Conversion Purposes -->
>>>>> <EnumerationType enumTypeId="CONVERSION_PURPOSE"  
>>>>> description="Conversion
>>>>> Purpose"/>
>>>>> <Enumeration enumId="INTERNAL_CONVERSION"
>>>>> enumTypeId="CONVERSION_PURPOSE" enumCode="INTERNAL"  
>>>>> sequenceId="10"
>>>>> description="Internal Conversion"/>
>>>>>
>>>>> Modified: ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/ 
>>>>> web.xml
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml?rev=750799&r1=750798&r2=750799&view=diff
>>>>>
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> = 
>>>>> ==================================================================
>>>>> --- ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>>>>> (original)
>>>>> +++ ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/ 
>>>>> web.xml Fri
>>>>> Mar 6 07:53:21 2009
>>>>> @@ -23,6 +23,12 @@
>>>>> <web-app>
>>>>> <display-name>Open For Business - Web Tools</display-name>
>>>>> <description>Common Application Components of the Open For  
>>>>> Business
>>>>> Project</description>
>>>>> +
>>>>> + <context-param>
>>>>> + <param-name>webSiteId</param-name>
>>>>> + <param-value>WEBTOOLS</param-value>
>>>>> + <description>A unique ID used to look up the WebSite entity to  
>>>>> get
>>>>> information about catalogs, etc.</description>
>>>>> + </context-param>
>>>>> <context-param>
>>>>> <param-name>entityDelegatorName</param-name>
>>>>> <param-value>default</param-value>
>>>>>
>>>>>
>>>>>
>>>
>>>
>>
>>