You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/14 18:05:01 UTC

[GitHub] [iceberg] rdblue opened a new pull request #1203: Remove table cache expiration

rdblue opened a new pull request #1203:
URL: https://github.com/apache/iceberg/pull/1203


   This removes table expiration from cache in `CachingCatalog`. As long as a reference to a table exists, the cache should continue to use that reference so that writes update the table for all queries. The cache still uses soft values, so once other references are removed it can be garbage collected if memory is needed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #1203: Remove table cache expiration

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1203:
URL: https://github.com/apache/iceberg/pull/1203#issuecomment-659731387


   @aokolnychyi, yes, that's what might happen. This would affect tables that are in logical plans that are cached or stored as temporary views.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] aokolnychyi commented on pull request #1203: Remove table cache expiration

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #1203:
URL: https://github.com/apache/iceberg/pull/1203#issuecomment-659727227


   Are we saying that we can hit a case when a table may be persisted as part of a logical plan in `tableRelationCache`, then it gets expired after 1 min from our catalog, then we have a write that loads a new table instead of refreshing the original one? And as a result, the table cached in `tableRelationCache` shows outdated results?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] aokolnychyi merged pull request #1203: Remove table cache expiration

Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #1203:
URL: https://github.com/apache/iceberg/pull/1203


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org