You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mumrah (via GitHub)" <gi...@apache.org> on 2025/02/20 18:18:15 UTC
[PR] KAFKA-18792 Add workflow to check PR format [kafka]
mumrah opened a new pull request, #18985:
URL: https://github.com/apache/kafka/pull/18985
Add a Python script to retrieve a PR using the GitHub CLI and validate its structure. For now this just includes the title and body, but could perform other non-code related checks in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18792 Add workflow to check PR format [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #18985:
URL: https://github.com/apache/kafka/pull/18985#issuecomment-2683221111
There was an OOM in one of the builds unrelated to this change. I'll investigate that separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18792 Add workflow to check PR format [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah merged PR #18985:
URL: https://github.com/apache/kafka/pull/18985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18792 Add workflow to check PR format [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #18985:
URL: https://github.com/apache/kafka/pull/18985#issuecomment-2675134424
To test this PR:
* Install `gh` if you don't have it already (`brew install gh`)
* Checkout this PR: `gh pr checkout 18985`
* Run the script against any PR
```
GITHUB_ACTIONS=1 PR_NUMBER=18955 python .github/scripts/pr-format.py
```
* Observe success or failure. Note that basically all PRs will fail the new required "Reviewers:" line in the PR body.
We cannot test the full automation until this PR is merged since part of the workflow runs off of trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18792 Add workflow to check PR format [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #18985:
URL: https://github.com/apache/kafka/pull/18985#issuecomment-2679034495
@jolshan yea, that's expected since this PR is not yet reviewed. If you try it on a reviewed PR, it should fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18792 Add workflow to check PR format [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #18985:
URL: https://github.com/apache/kafka/pull/18985#issuecomment-2676326460
I ran the command on this PR and it seems to have passed. Is that expected?
```
GITHUB_ACTIONS=1 PR_NUMBER=18985 python .github/scripts/pr-format.py
Read env GITHUB_ACTIONS: 1
Read env PR_NUMBER: 18985
PR format looks good!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org