You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by zellerh <gi...@git.apache.org> on 2018/02/21 18:26:01 UTC
[GitHub] trafodion pull request #1451: [TRAFODION-2965] Fix row count stats for parti...
GitHub user zellerh opened a pull request:
https://github.com/apache/trafodion/pull/1451
[TRAFODION-2965] Fix row count stats for partial groupby
Hash partial groupbys now report their row count in operator-level
statistics. These are not considered BMOs, so they need to use the
generic stats entry, not the BMO stats, to report the row count.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zellerh/trafodion bug/R23
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1451.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1451
----
commit 39a3f2047a847768ddcc84b7a549eb322b7b4c48
Author: Hans Zeller <hz...@...>
Date: 2018-02-21T18:23:20Z
[TRAFODION-2965] Fix row count stats for partial groupby
Hash partial groupbys now report their row count in operator-level
statistics. These are not considered BMOs, so they need to use the
generic stats entry, not the BMO stats, to report the row count.
----
---
[GitHub] trafodion pull request #1451: [TRAFODION-2965] Fix row count stats for parti...
Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1451#discussion_r169734207
--- Diff: core/sql/executor/ex_hash_grby.cpp ---
@@ -1027,8 +1027,10 @@ void ex_hash_grby_tcb::returnResultCurrentRow(HashRow * dataPointer)
upParentEntry->upState.downIndex = parentQueue_.down->getHeadIndex();
// if stats are to be collected, collect them.
- if (bmoStats_)
- bmoStats_->incActualRowsReturned();
+ ExOperStats *statsEntry = getStatsEntry();
--- End diff --
bmoStats_ is also used for reporting memory-related counters, so we still need it.
---
[GitHub] trafodion pull request #1451: [TRAFODION-2965] Fix row count stats for parti...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1451#discussion_r169733349
--- Diff: core/sql/executor/ex_hash_grby.cpp ---
@@ -1027,8 +1027,10 @@ void ex_hash_grby_tcb::returnResultCurrentRow(HashRow * dataPointer)
upParentEntry->upState.downIndex = parentQueue_.down->getHeadIndex();
// if stats are to be collected, collect them.
- if (bmoStats_)
- bmoStats_->incActualRowsReturned();
+ ExOperStats *statsEntry = getStatsEntry();
--- End diff --
Is the member bmoStats_ no longer used then? Should it be deleted?
---
[GitHub] trafodion pull request #1451: [TRAFODION-2965] Fix row count stats for parti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1451
---