You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2015/11/11 20:40:33 UTC

[GitHub] spark pull request: [SPARK-11647] Attempt to reduce time/flakiness...

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9623#discussion_r44576116
  
    --- Diff: core/src/test/scala/org/apache/spark/deploy/RPackageUtilsSuite.scala ---
    @@ -60,11 +64,9 @@ class RPackageUtilsSuite extends SparkFunSuite with BeforeAndAfterEach {
         }
       }
     
    -  def beforeAll() {
    -    System.setProperty("spark.testing", "true")
    -  }
    -
       override def beforeEach(): Unit = {
    +    super.beforeEach()
    +    System.setProperty("spark.testing", "true")
    --- End diff --
    
    what's the difference between having it in beforeEach and beforeAll for this specific config?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org