You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/07 18:07:10 UTC
[jira] [Commented] (SHIRO-330) Refactor Cookie / Simple Cookie &
Add Encrypted Cookie
[ https://issues.apache.org/jira/browse/SHIRO-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366515#comment-15366515 ]
ASF GitHub Bot commented on SHIRO-330:
--------------------------------------
GitHub user bdemers opened a pull request:
https://github.com/apache/shiro/pull/28
WIP: Applying patch from SHIRO-330 Encrypted Cookie
Creating pull request, because it is easier then dealing with patch files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bdemers/shiro SHIRO-330
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/shiro/pull/28.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #28
----
commit 7f9d37ade2fa705dcf97c645cfd8c6270dedd95f
Author: Brian Demers <bd...@apache.org>
Date: 2016-07-07T18:05:04Z
Applying patch from SHIRO-330 Encrypted Cookie
----
> Refactor Cookie / Simple Cookie & Add Encrypted Cookie
> -------------------------------------------------------
>
> Key: SHIRO-330
> URL: https://issues.apache.org/jira/browse/SHIRO-330
> Project: Shiro
> Issue Type: New Feature
> Components: Web
> Affects Versions: 1.2.0
> Reporter: Allan Ditzel
> Priority: Minor
> Labels: patch, patch-with-test
> Fix For: 1.3.0
>
> Attachments: encrypted_cookie1.patch
>
>
> The current Cookie/SimpleCookie mechanism blends usage and creational concerns, i.e. the cookie both holds state and is a factory, acting as a template to create new cookie instances. These concerns should be separated.
> In addition, it would be nice to have an encrypted cookie mechanism. Attached there is a patch for an initial implementation of an encrypted cookie based on 1.2.0 code. It's been added to capture the intent behind the cookie and to quickly patch the code base with this functionality before refactoring in a future version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)