You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Cody Gibb <co...@gmail.com> on 2017/02/02 00:44:01 UTC
Re: Review Request 54459: Add message parameter to killTasks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------
(Updated Feb. 2, 2017, 12:43 a.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Changes
-------
Rebase
Bugs: AURORA-1846
https://issues.apache.org/jira/browse/AURORA-1846
Repository: aurora
Description
-------
RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
Diffs (updated)
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
Diff: https://reviews.apache.org/r/54459/diff/
Testing
-------
Added a unit test in the scheduler, and a test in the client.
Also manually tested using the Vagrant environment.
File Attachments
----------------
"Some message" shown in UI
https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
Thanks,
Cody Gibb
Re: Review Request 54459: Add message parameter to killTasks
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163995
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Feb. 2, 2017, 12:57 a.m., Cody Gibb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 12:57 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1846
> https://issues.apache.org/jira/browse/AURORA-1846
>
>
> Repository: aurora
>
>
> Description
> -------
>
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
>
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
>
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
> src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
> src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
> src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
> src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
> src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
> src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
> src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
>
> Diff: https://reviews.apache.org/r/54459/diff/
>
>
> Testing
> -------
>
> Added a unit test in the scheduler, and a test in the client.
>
> Also manually tested using the Vagrant environment.
>
>
> File Attachments
> ----------------
>
> "Some message" shown in UI
> https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
>
>
> Thanks,
>
> Cody Gibb
>
>
Re: Review Request 54459: Add message parameter to killTasks
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review164388
-----------------------------------------------------------
Ship it!
Master (7de6d34) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 6, 2017, 6:40 p.m., Cody Gibb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 6:40 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1846
> https://issues.apache.org/jira/browse/AURORA-1846
>
>
> Repository: aurora
>
>
> Description
> -------
>
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
>
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
>
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 05fdfb6f7ec5b19986afbc89de33f2773d62b363
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
> src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
> src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
> src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
> src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
> src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
> src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
> src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
>
> Diff: https://reviews.apache.org/r/54459/diff/
>
>
> Testing
> -------
>
> Added a unit test in the scheduler, and a test in the client.
>
> Also manually tested using the Vagrant environment.
>
>
> File Attachments
> ----------------
>
> "Some message" shown in UI
> https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
>
>
> Thanks,
>
> Cody Gibb
>
>
Re: Review Request 54459: Add message parameter to killTasks
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review164384
-----------------------------------------------------------
This change is now on master.
- Zameer Manji
On Feb. 6, 2017, 10:40 a.m., Cody Gibb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 10:40 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1846
> https://issues.apache.org/jira/browse/AURORA-1846
>
>
> Repository: aurora
>
>
> Description
> -------
>
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
>
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
>
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 05fdfb6f7ec5b19986afbc89de33f2773d62b363
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
> src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
> src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
> src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
> src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
> src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
> src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
> src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
>
> Diff: https://reviews.apache.org/r/54459/diff/
>
>
> Testing
> -------
>
> Added a unit test in the scheduler, and a test in the client.
>
> Also manually tested using the Vagrant environment.
>
>
> File Attachments
> ----------------
>
> "Some message" shown in UI
> https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
>
>
> Thanks,
>
> Cody Gibb
>
>
Re: Review Request 54459: Add message parameter to killTasks
Posted by Cody Gibb <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 6:40 p.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Changes
-------
Update release notes
Bugs: AURORA-1846
https://issues.apache.org/jira/browse/AURORA-1846
Repository: aurora
Description
-------
RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
Diffs (updated)
-----
RELEASE-NOTES.md 05fdfb6f7ec5b19986afbc89de33f2773d62b363
api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
Diff: https://reviews.apache.org/r/54459/diff/
Testing
-------
Added a unit test in the scheduler, and a test in the client.
Also manually tested using the Vagrant environment.
File Attachments
----------------
"Some message" shown in UI
https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
Thanks,
Cody Gibb
Re: Review Request 54459: Add message parameter to killTasks
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review164381
-----------------------------------------------------------
Ship it!
Please add an entry in the release notes for 0.18.0 and I'll land this.
- Zameer Manji
On Feb. 1, 2017, 4:57 p.m., Cody Gibb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 4:57 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1846
> https://issues.apache.org/jira/browse/AURORA-1846
>
>
> Repository: aurora
>
>
> Description
> -------
>
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
>
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
>
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
> src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
> src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
> src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
> src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
> src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
> src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
> src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
>
> Diff: https://reviews.apache.org/r/54459/diff/
>
>
> Testing
> -------
>
> Added a unit test in the scheduler, and a test in the client.
>
> Also manually tested using the Vagrant environment.
>
>
> File Attachments
> ----------------
>
> "Some message" shown in UI
> https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
>
>
> Thanks,
>
> Cody Gibb
>
>
Re: Review Request 54459: Add message parameter to killTasks
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163922
-----------------------------------------------------------
@ReviewBot retry
- Zameer Manji
On Feb. 1, 2017, 4:57 p.m., Cody Gibb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 4:57 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1846
> https://issues.apache.org/jira/browse/AURORA-1846
>
>
> Repository: aurora
>
>
> Description
> -------
>
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
>
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
>
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
> src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
> src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
> src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
> src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
> src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
> src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
> src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
>
> Diff: https://reviews.apache.org/r/54459/diff/
>
>
> Testing
> -------
>
> Added a unit test in the scheduler, and a test in the client.
>
> Also manually tested using the Vagrant environment.
>
>
> File Attachments
> ----------------
>
> "Some message" shown in UI
> https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
>
>
> Thanks,
>
> Cody Gibb
>
>
Re: Review Request 54459: Add message parameter to killTasks
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163923
-----------------------------------------------------------
Ship it!
Master (7de6d34) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 2, 2017, 12:57 a.m., Cody Gibb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 12:57 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1846
> https://issues.apache.org/jira/browse/AURORA-1846
>
>
> Repository: aurora
>
>
> Description
> -------
>
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
>
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
>
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
> src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
> src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
> src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
> src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
> src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
> src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
> src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
>
> Diff: https://reviews.apache.org/r/54459/diff/
>
>
> Testing
> -------
>
> Added a unit test in the scheduler, and a test in the client.
>
> Also manually tested using the Vagrant environment.
>
>
> File Attachments
> ----------------
>
> "Some message" shown in UI
> https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
>
>
> Thanks,
>
> Cody Gibb
>
>
Re: Review Request 54459: Add message parameter to killTasks
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163921
-----------------------------------------------------------
Master (7de6d34) is red with this patch.
./build-support/jenkins/build.sh
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/lmdb
creating build/temp.linux-x86_64-2.7/lib
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -Ilib/py-lmdb -Ilib -I/usr/include/python2.7 -c lmdb/cpython.c -o build/temp.linux-x86_64-2.7/lmdb/cpython.o -UNDEBUG -w
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -Ilib/py-lmdb -Ilib -I/usr/include/python2.7 -c lib/mdb.c -o build/temp.linux-x86_64-2.7/lib/mdb.o -UNDEBUG -w
Assembler messages:
Fatal error: can't create build/temp.linux-x86_64-2.7/lib/mdb.o: No such file or directory
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
----------------------------------------
Failed building wheel for lmdb
Running setup.py clean for lmdb
Exception:
Traceback (most recent call last):
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/basecommand.py", line 215, in main
status = self.run(options, args)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/commands/install.py", line 310, in run
wb.build(autobuilding=True)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/wheel.py", line 814, in build
python_tag=python_tag,
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/wheel.py", line 700, in _build_one
rmtree(tempd)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/_vendor/retrying.py", line 49, in wrapped_f
return Retrying(*dargs, **dkw).call(f, *args, **kw)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/_vendor/retrying.py", line 212, in call
raise attempt.get()
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/_vendor/retrying.py", line 247, in get
six.reraise(self.value[0], self.value[1], self.value[2])
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/_vendor/retrying.py", line 200, in call
attempt = Attempt(fn(*args, **kwargs), attempt_number, False)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/utils/__init__.py", line 102, in rmtree
onerror=rmtree_errorhandler)
File "/usr/lib/python2.7/shutil.py", line 239, in rmtree
onerror(os.listdir, path, sys.exc_info())
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/utils/__init__.py", line 110, in rmtree_errorhandler
if os.stat(path).st_mode & stat.S_IREAD:
OSError: [Errno 2] No such file or directory: '/tmp/tmpZOIF9Spip-wheel-'
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/../../pants: line 99: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.3.0.dev3/bin/python: No such file or directory
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 2, 2017, 12:57 a.m., Cody Gibb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 12:57 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1846
> https://issues.apache.org/jira/browse/AURORA-1846
>
>
> Repository: aurora
>
>
> Description
> -------
>
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
>
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
>
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
> src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
> src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
> src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
> src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
> src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
> src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
> src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
>
> Diff: https://reviews.apache.org/r/54459/diff/
>
>
> Testing
> -------
>
> Added a unit test in the scheduler, and a test in the client.
>
> Also manually tested using the Vagrant environment.
>
>
> File Attachments
> ----------------
>
> "Some message" shown in UI
> https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
>
>
> Thanks,
>
> Cody Gibb
>
>
Re: Review Request 54459: Add message parameter to killTasks
Posted by Cody Gibb <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------
(Updated Feb. 2, 2017, 12:57 a.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Changes
-------
Fix unused import
Bugs: AURORA-1846
https://issues.apache.org/jira/browse/AURORA-1846
Repository: aurora
Description
-------
RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
Diffs (updated)
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
Diff: https://reviews.apache.org/r/54459/diff/
Testing
-------
Added a unit test in the scheduler, and a test in the client.
Also manually tested using the Vagrant environment.
File Attachments
----------------
"Some message" shown in UI
https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
Thanks,
Cody Gibb
Re: Review Request 54459: Add message parameter to killTasks
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163916
-----------------------------------------------------------
Master (7de6d34) is red with this patch.
./build-support/jenkins/build.sh
:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74: Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:41: Wrong order for 'org.apache.aurora.common.args.OptionInfo' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ImportOrder]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:41:8: Unused import - org.apache.aurora.common.args.OptionInfo. [UnusedImports]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 14.04 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 2, 2017, 12:43 a.m., Cody Gibb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 12:43 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1846
> https://issues.apache.org/jira/browse/AURORA-1846
>
>
> Repository: aurora
>
>
> Description
> -------
>
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
>
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
>
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7
> src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
> src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
> src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d
> src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7
> src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780
> src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
> src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca
>
> Diff: https://reviews.apache.org/r/54459/diff/
>
>
> Testing
> -------
>
> Added a unit test in the scheduler, and a test in the client.
>
> Also manually tested using the Vagrant environment.
>
>
> File Attachments
> ----------------
>
> "Some message" shown in UI
> https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
>
>
> Thanks,
>
> Cody Gibb
>
>