You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/05/02 01:38:45 UTC

[GitHub] [nifi] joewitt commented on pull request #4242: NIFI-7411: Integrate H2O Driverless AI MSP in NiFi

joewitt commented on pull request #4242:
URL: https://github.com/apache/nifi/pull/4242#issuecomment-622650342


   I don’t think this makes sense to include in Apache nifi.  Rather h2o should maintain and publish this nar for their users.  Similar to what other vendors with similar desired integrations have done.
   
   The two binary source files are not allowed.
   
   It doesn’t appear this would run unless a user supplied a licensed jar from h2o.   This also makes me very suspicious of what we included for minificpp which already got merged.
   
   The name of the processor does not help a user know what it is.  Should be ExecuteH2OScoringPipeline perhaps.
   
   The logging stuff should be removed most likely.
   
   Please correct me if wrong on above understanding.  If I’m not wrong this should be an h2o managed/maintained/published thing.  Happy to see us point out it exists from our site though.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org