You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by kx...@apache.org on 2023/06/26 12:35:55 UTC
[doris] 02/09: [fix](inverted index) fix build inverted index failed but not return immediately (#21165)
This is an automated email from the ASF dual-hosted git repository.
kxiao pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 507b98a0cb66ed60146d64449dd44633b6e75ad3
Author: YueW <45...@users.noreply.github.com>
AuthorDate: Mon Jun 26 14:05:12 2023 +0800
[fix](inverted index) fix build inverted index failed but not return immediately (#21165)
---
be/src/olap/task/index_builder.cpp | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/be/src/olap/task/index_builder.cpp b/be/src/olap/task/index_builder.cpp
index b7d93120aa..05ba099f90 100644
--- a/be/src/olap/task/index_builder.cpp
+++ b/be/src/olap/task/index_builder.cpp
@@ -333,7 +333,7 @@ Status IndexBuilder::_add_data(const std::string& column_name,
}
Status IndexBuilder::handle_inverted_index_data() {
- LOG(INFO) << "begint to handle_inverted_index_data";
+ LOG(INFO) << "begin to handle_inverted_index_data";
DCHECK(_input_rowsets.size() == _output_rowsets.size());
for (auto i = 0; i < _output_rowsets.size(); ++i) {
SegmentCacheHandle segment_cache_handle;
@@ -347,7 +347,7 @@ Status IndexBuilder::handle_inverted_index_data() {
}
Status IndexBuilder::do_build_inverted_index() {
- LOG(INFO) << "begine to do_build_inverted_index, tablet=" << _tablet->tablet_id()
+ LOG(INFO) << "begin to do_build_inverted_index, tablet=" << _tablet->tablet_id()
<< ", is_drop_op=" << _is_drop_op;
if (_alter_inverted_indexes.empty()) {
return Status::OK();
@@ -403,6 +403,7 @@ Status IndexBuilder::do_build_inverted_index() {
LOG(WARNING) << "failed to update_inverted_index_info. "
<< "tablet=" << _tablet->tablet_id() << ", error=" << st;
gc_output_rowset();
+ return st;
}
// create inverted index file for output rowset
@@ -411,6 +412,7 @@ Status IndexBuilder::do_build_inverted_index() {
LOG(WARNING) << "failed to handle_inverted_index_data. "
<< "tablet=" << _tablet->tablet_id() << ", error=" << st;
gc_output_rowset();
+ return st;
}
// modify rowsets in memory
@@ -419,8 +421,9 @@ Status IndexBuilder::do_build_inverted_index() {
LOG(WARNING) << "failed to modify rowsets in memory. "
<< "tablet=" << _tablet->tablet_id() << ", error=" << st;
gc_output_rowset();
+ return st;
}
- return st;
+ return Status::OK();
}
Status IndexBuilder::modify_rowsets(const Merger::Statistics* stats) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org