[GitHub] [hadoop-ozone] elek commented on a change in pull request #763: HDDS-3302. Add ability in MiniOzoneCluster to create multiple storage directories.

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #763: HDDS-3302. Add ability in MiniOzoneCluster to create multiple storage directories.
URL: https://github.com/apache/hadoop-ozone/pull/763#discussion_r404677222
 
 

 ##########
 File path: hadoop-ozone/fault-injection-test/mini-chaos-tests/src/test/java/org/apache/hadoop/ozone/TestMiniChaosOzoneCluster.java
 ##########
 @@ -123,6 +133,8 @@ public void run() {
       cluster.startChaos(failureInterval, failureInterval, TimeUnit.SECONDS);
       loadGenerator.startIO(numMinutes, TimeUnit.MINUTES);
     } catch (Exception e) {
+      LOG.error("terminating with exception", e);
+      ExitUtil.terminate(-2, e);
 
 Review comment:
   Can you please help to understand the motivation behind this? I thought that if an exception is thrown the exit code will be non-zero anyway (If something is wrong with the error handling, GenericCli might already have the solution. As I remember it has some generic error handling logic).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org