[GitHub] [incubator-inlong] kipshi commented on a change in pull request #2412: [INLONG-2410] Inlong Manager support business workflow suspend | restart | delete

[GitBox <gi...@apache.org>]

kipshi commented on a change in pull request #2412:
URL: https://github.com/apache/incubator-inlong/pull/2412#discussion_r802280036



##########
File path: inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/BusinessController.java
##########
@@ -86,7 +86,8 @@
     @OperationLog(operation = OperationType.DELETE)
     @ApiImplicitParam(name = "groupId", value = "Business group id", dataTypeClass = String.class, required = true)
     public Response<Boolean> delete(@PathVariable String groupId) {
-        return Response.success(businessService.delete(groupId, LoginUserUtil.getLoginUserDetail().getUserName()));
+        return Response.success(bizProcessOperation.deleteProcess(groupId, 

Review comment:
       BusinessProcessOperation will invoke BusinessService to logically delete data, I think data changing should all lay up cohensively in BusinessService, and repository class should not be invoked directly by other classes;




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org