You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/25 11:55:20 UTC
[GitHub] [cordova-plugin-inappbrowser] j--w opened a new pull request #654:
[GH-652] add check for openInSystem postNotification
j--w opened a new pull request #654: [GH-652] add check for openInSystem postNotification
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/654
### Platforms affected
iOS
### Motivation and Context
fixes #652
This fix prevents window.handleOpenURL from being triggered by calls to _system browser through InAppBrowser which was previously fixed in UIWebView version of IAB but still exists in WKWebView version
### Description
Add ` if ([[UIApplication sharedApplication] openURL:url] == NO)` check in openInSystem method which was present in UIWebView version of IAB but not WKWebView.
### Testing
Ran plugintests repo
Manually tested in my own project where I first noticed the issue
Manually tested in minimum reproduction repo and pushed [to a branch](https://github.com/j--w/iab-handleopenurl-bug/commit/e910b312cb606eee2d3c922c70bf696117cfa2f3)
### Checklist
- [X] I've run the tests to see all new and existing tests pass
- [X] I added automated test coverage as appropriate for this change
- [X] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [X] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 merged pull request #654:
[GH-652] add check for openInSystem postNotification
Posted by GitBox <gi...@apache.org>.
timbru31 merged pull request #654: [GH-652] add check for openInSystem postNotification
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/654
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #654:
[GH-652] add check for openInSystem postNotification
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #654: [GH-652] add check for openInSystem postNotification
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/654#issuecomment-603828702
Great, thanks for your PR. Code wise it looks good. I'll test your branch later today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org