You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/13 01:46:54 UTC
[GitHub] [airflow] mmoyses opened a new pull request #14220: S3DataSource is not required
mmoyses opened a new pull request #14220:
URL: https://github.com/apache/airflow/pull/14220
A channel's datasource can be a file system or S3. The code shouldn't assume all datasources are S3 datasources and try to verify the URI.
Documentation showing the filed "S3DataSource" is not required: https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_DataSource.html
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14220: S3DataSource is not required
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14220:
URL: https://github.com/apache/airflow/pull/14220#issuecomment-779205918
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14220: S3DataSource is not required
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14220:
URL: https://github.com/apache/airflow/pull/14220#issuecomment-779254003
You've got some test failures to examine it looks like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14220: S3DataSource is not required
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14220:
URL: https://github.com/apache/airflow/pull/14220#issuecomment-778542251
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14220: S3DataSource is not required
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14220:
URL: https://github.com/apache/airflow/pull/14220#issuecomment-780603286
Sorry, GitHub have messed up something to do with our permissions, so the CI is currently not working :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14220: S3DataSource is not required
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14220:
URL: https://github.com/apache/airflow/pull/14220#issuecomment-791493107
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #14220: S3DataSource is not required
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #14220:
URL: https://github.com/apache/airflow/pull/14220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb removed a comment on pull request #14220: S3DataSource is not required
Posted by GitBox <gi...@apache.org>.
ashb removed a comment on pull request #14220:
URL: https://github.com/apache/airflow/pull/14220#issuecomment-780603286
Sorry, GitHub have messed up something to do with our permissions, so the CI is currently not working :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14220: S3DataSource is not required
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14220:
URL: https://github.com/apache/airflow/pull/14220#issuecomment-791421628
Closing and re-opening to trigger tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14220: S3DataSource is not required
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14220:
URL: https://github.com/apache/airflow/pull/14220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mmoyses commented on pull request #14220: S3DataSource is not required
Posted by GitBox <gi...@apache.org>.
mmoyses commented on pull request #14220:
URL: https://github.com/apache/airflow/pull/14220#issuecomment-778828611
Updated the PR with some tests for file system data sources
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org