You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/02/26 02:55:14 UTC

[GitHub] [echarts] pissang commented on issue #14351: Install themes from npm

pissang commented on issue #14351:
URL: https://github.com/apache/echarts/issues/14351#issuecomment-786375482


   > 1) The current UMD header invalidates tree-shaking, which makes the bundled size larger.
   
   Because `echarts/lib/echarts` is not an AMD module. So I still use `echarts` in the AMD branch. Didn't know the bundler will still go into the AMD branch. This change is very neat and helpful.
   
   
   > Perhaps, we should also make the theme or extension installable.
   
   Yes, it will be great. But we may need to provide separate ESM modules for themes that can be installed manually.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org