You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Elliott Clark (JIRA)" <ji...@apache.org> on 2012/10/23 01:22:16 UTC
[jira] [Created] (HBASE-7032) Remove old IncrementColumnValue code.
Elliott Clark created HBASE-7032:
------------------------------------
Summary: Remove old IncrementColumnValue code.
Key: HBASE-7032
URL: https://issues.apache.org/jira/browse/HBASE-7032
Project: HBase
Issue Type: Task
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Minor
IncrementColumnValue under the covers now uses Increment. We should remove the old code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7032) Remove old IncrementColumnValue
code.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482833#comment-13482833 ]
Hudson commented on HBASE-7032:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #232 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/232/])
HBASE-7032 Remove old IncrementColumnValue code. (Revision 1401447)
Result = FAILURE
eclark :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
> Remove old IncrementColumnValue code.
> -------------------------------------
>
> Key: HBASE-7032
> URL: https://issues.apache.org/jira/browse/HBASE-7032
> Project: HBase
> Issue Type: Task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7032-0.patch
>
>
> IncrementColumnValue under the covers now uses Increment. We should remove the old code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7032) Remove old IncrementColumnValue code.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7032:
---------------------------------
Status: Patch Available (was: Open)
> Remove old IncrementColumnValue code.
> -------------------------------------
>
> Key: HBASE-7032
> URL: https://issues.apache.org/jira/browse/HBASE-7032
> Project: HBase
> Issue Type: Task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-7032-0.patch
>
>
> IncrementColumnValue under the covers now uses Increment. We should remove the old code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7032) Remove old IncrementColumnValue
code.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482622#comment-13482622 ]
stack commented on HBASE-7032:
------------------------------
Was going to ask when it was deprecated but I see HRegion private. +1 on commit.
> Remove old IncrementColumnValue code.
> -------------------------------------
>
> Key: HBASE-7032
> URL: https://issues.apache.org/jira/browse/HBASE-7032
> Project: HBase
> Issue Type: Task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-7032-0.patch
>
>
> IncrementColumnValue under the covers now uses Increment. We should remove the old code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7032) Remove old IncrementColumnValue
code.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482604#comment-13482604 ]
Hadoop QA commented on HBASE-7032:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12550508/HBASE-7032-0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 82 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestDrainingServer
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3127//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3127//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3127//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3127//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3127//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3127//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3127//console
This message is automatically generated.
> Remove old IncrementColumnValue code.
> -------------------------------------
>
> Key: HBASE-7032
> URL: https://issues.apache.org/jira/browse/HBASE-7032
> Project: HBase
> Issue Type: Task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-7032-0.patch
>
>
> IncrementColumnValue under the covers now uses Increment. We should remove the old code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7032) Remove old IncrementColumnValue code.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7032:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed revision 1401447.
Thanks for the review Stack.
> Remove old IncrementColumnValue code.
> -------------------------------------
>
> Key: HBASE-7032
> URL: https://issues.apache.org/jira/browse/HBASE-7032
> Project: HBase
> Issue Type: Task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7032-0.patch
>
>
> IncrementColumnValue under the covers now uses Increment. We should remove the old code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7032) Remove old IncrementColumnValue
code.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482753#comment-13482753 ]
Hudson commented on HBASE-7032:
-------------------------------
Integrated in HBase-TRUNK #3477 (See [https://builds.apache.org/job/HBase-TRUNK/3477/])
HBASE-7032 Remove old IncrementColumnValue code. (Revision 1401447)
Result = FAILURE
eclark :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
> Remove old IncrementColumnValue code.
> -------------------------------------
>
> Key: HBASE-7032
> URL: https://issues.apache.org/jira/browse/HBASE-7032
> Project: HBase
> Issue Type: Task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7032-0.patch
>
>
> IncrementColumnValue under the covers now uses Increment. We should remove the old code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7032) Remove old IncrementColumnValue code.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7032:
---------------------------------
Attachment: HBASE-7032-0.patch
incrementColumnValue in hregion is no longer used. It's only used in tests now that HRegion.increment() is handling all calls from HRegionServer.incrementColumnValue().
> Remove old IncrementColumnValue code.
> -------------------------------------
>
> Key: HBASE-7032
> URL: https://issues.apache.org/jira/browse/HBASE-7032
> Project: HBase
> Issue Type: Task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-7032-0.patch
>
>
> IncrementColumnValue under the covers now uses Increment. We should remove the old code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira