You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by lqjack <gi...@git.apache.org> on 2017/06/20 15:45:33 UTC

[GitHub] incubator-rocketmq pull request #125: ROCKETMQ-205 :

GitHub user lqjack opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/125

    ROCKETMQ-205 :

     change the constant to variable

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lqjack/incubator-rocketmq ROCKETMQ-205

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit ff16d7a7a46a1b82db67aee5ed8cce7865ae72bf
Author: lqjaclee <lq...@126.com>
Date:   2017-06-20T15:45:49Z

    ROCKETMQ-205 : change the constant to variable

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #125: ROCKETMQ-205 :

Posted by vongosling <gi...@git.apache.org>.

Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/125
  
    @lqjack what's your opinion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #125: ROCKETMQ-205 :

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-rocketmq/pull/125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #125: ROCKETMQ-205 :

Posted by dongeforever <gi...@git.apache.org>.

Github user dongeforever commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/125
  
    @lqjack Thanks for you contribution. You may want to refactor the PR name and attach the jira issue in the comment.
    It is better to add some detailed words to the PR name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---