You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/04/04 23:25:29 UTC
[Impala-ASF-CR] IMPALA-6549: [DOCS] Update the known issue for HDFS-12528
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9929
Change subject: IMPALA-6549: [DOCS] Update the known issue for HDFS-12528
......................................................................
IMPALA-6549: [DOCS] Update the known issue for HDFS-12528
Added a new recommendation for the new setting with the fix version
of HDFS, 2.10 and higher.
Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
---
M docs/topics/impala_known_issues.xml
1 file changed, 30 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/9929/1
--
To view, visit http://gerrit.cloudera.org:8080/9929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
Gerrit-Change-Number: 9929
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9929 )
Change subject: IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
Gerrit-Change-Number: 9929
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Apr 2018 23:35:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9929
to look at the new patch set (#3).
Change subject: IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
......................................................................
IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
Added a new recommendation for the new setting with the fix version
of HDFS, 2.10 and higher.
Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
---
M docs/topics/impala_known_issues.xml
1 file changed, 45 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/9929/3
--
To view, visit http://gerrit.cloudera.org:8080/9929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
Gerrit-Change-Number: 9929
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6549: [DOCS] Update the known issue for HDFS-12528
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9929 )
Change subject: IMPALA-6549: [DOCS] Update the known issue for HDFS-12528
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9929/2/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
http://gerrit.cloudera.org:8080/#/c/9929/2/docs/topics/impala_known_issues.xml@450
PS2, Line 450: to be
"to be" -> "are"
I'd like this sentence to be clear about when short circuit reads are disabled. Something like:
Use the new HDFS parameter blah to specify the amount of time short circuit reads are disabled on encountering an error.
http://gerrit.cloudera.org:8080/#/c/9929/2/docs/topics/impala_known_issues.xml@453
PS2, Line 453:
Nit: stray space
http://gerrit.cloudera.org:8080/#/c/9929/2/docs/topics/impala_known_issues.xml@453
PS2, Line 453: 0
: is not recommended.
Setting dfs.domain.socket.disable.interval.seconds to 0 is not recommended, as a non-zero interval protects the system if there is a persistent problem with short circuit reads.
--
To view, visit http://gerrit.cloudera.org:8080/9929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
Gerrit-Change-Number: 9929
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Apr 2018 16:25:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6549: [DOCS] Update the known issue for HDFS-12528
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9929 )
Change subject: IMPALA-6549: [DOCS] Update the known issue for HDFS-12528
......................................................................
IMPALA-6549: [DOCS] Update the known issue for HDFS-12528
Added a new recommendation for the new setting with the fix version
of HDFS, 2.10 and higher.
Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
---
M docs/topics/impala_known_issues.xml
1 file changed, 40 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/9929/2
--
To view, visit http://gerrit.cloudera.org:8080/9929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
Gerrit-Change-Number: 9929
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9929 )
Change subject: IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
......................................................................
IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
Added a new recommendation for the new setting with the fix version
of HDFS, 2.10 and higher.
Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
Reviewed-on: http://gerrit.cloudera.org:8080/9929
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_known_issues.xml
1 file changed, 45 insertions(+), 16 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
Gerrit-Change-Number: 9929
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9929 )
Change subject: IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/225/
--
To view, visit http://gerrit.cloudera.org:8080/9929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
Gerrit-Change-Number: 9929
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Apr 2018 23:27:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9929 )
Change subject: IMPALA-6807: [DOCS] Update the known issue for HDFS-12528
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
Gerrit-Change-Number: 9929
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Apr 2018 23:17:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6549: [DOCS] Update the known issue for HDFS-12528
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9929 )
Change subject: IMPALA-6549: [DOCS] Update the known issue for HDFS-12528
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9929/2/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
http://gerrit.cloudera.org:8080/#/c/9929/2/docs/topics/impala_known_issues.xml@450
PS2, Line 450: to be
> "to be" -> "are"
Done
http://gerrit.cloudera.org:8080/#/c/9929/2/docs/topics/impala_known_issues.xml@453
PS2, Line 453:
> Nit: stray space
Done
http://gerrit.cloudera.org:8080/#/c/9929/2/docs/topics/impala_known_issues.xml@453
PS2, Line 453: 0
: is not recommended.
> Setting dfs.domain.socket.disable.interval.seconds to 0 is not recommended,
Done
--
To view, visit http://gerrit.cloudera.org:8080/9929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If51cb111a9ddc67be4a1cf42502a8a021486b7e4
Gerrit-Change-Number: 9929
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Apr 2018 16:47:59 +0000
Gerrit-HasComments: Yes