You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/03/22 04:50:30 UTC
[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2174
[ZEPELIN-2209] Add pagination to Helium menu
### What is this PR for?
Like I did in #2126, added pagination to Helium menu in Zeppelin.
10 pkgs will be shown per 1 page.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2209](https://issues.apache.org/jira/browse/ZEPPELIN-2209)
### How should this be tested?
1. Replace temporarily [ZeppelinConfiguration.java#L46](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L46) with [this url](https://raw.githubusercontent.com/AhyoungRyu/spark-notebook-example/master/helium.json)
2. Build \w below command and restart Zeppelin server
```
$ mvn clean package -DskipTests -pl 'zeppelin-zengine, zeppelin-server, zeppelin-interpreter'
```
3. Start web dev server under `ZEPPELIN_HOME/zeppelin-web` and browse `localhost:9000`
```
$ yarn run dev
```
4. Go to Helium menu -> Click `INTERPRETER` btn
(Currently the other types of pkg are registered in online registry less than 10. That's why I request to change online registry URI in step 1)
5. Check the pagination works well or not
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin add/paginationToHeliumMenu
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2174
----
commit 81a245fcd9220fee2d2a132d5a042caa41c9b454
Author: RyuAhyoung <ah...@macbook-pro-5.local>
Date: 2017-03-22T04:35:41Z
Add pagination to Helium menu
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda It's wired. This is what I can see when I build my branch.
There are two `ng-repeat` like below. And [the pagination DOM](https://github.com/AhyoungRyu/zeppelin/blob/7150e7cb596c2bbe9148ea2a09009c6fb273a20e/zeppelin-web/src/app/helium/helium.html#L195) is placed inside of the first `ng-repeat`(for pkg type checking loop) and outside of the second one(each type of package listing).
<img width="913" alt="screen shot 2017-03-28 at 12 10 18 am" src="https://cloud.githubusercontent.com/assets/10060731/24363549/26531e08-134b-11e7-8f05-4b71bf1b277b.png">
FYI, the data is like this.
<img width="215" alt="screen shot 2017-03-28 at 12 12 37 am" src="https://cloud.githubusercontent.com/assets/10060731/24363853/ff811018-134b-11e7-84a3-867ec956539e.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@felixcheung Let me check again for that part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@AhyoungRyu Tested and works as described. LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda Will be really appreciated if you can help review this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2174
ok to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda I updated the pagination as you said and this is the current status. Will be appreciated if you can take a look again.
@felixcheung I set the maximum pagination size as "5" and tested in the smallest mobile device size that Chrome dev tool provides (`320 x 568`) like below.
The pagination is not broken when the screen is small. But `enable` btn and package type selection btn are broken instead \U0001f605 Let me handle them in another PR. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/2174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@AhyoungRyu more precisely,
1. If we are in page 1, we don't need `<<`
2. If we are in some pages which can go to page 1, we need both `<<` && `>>`
3. the last case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda No worries :)
Then how about 1 page ? I mean if there is only 1 page, we can hide `<<` & `>>`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@felixcheung Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda I fixed it in the latest commit bc7643c46dc6690b5b1f1a91249bcf4ee0e93a43. You can simply check whether it was fixed or not by comparing `INTERPRETER` type of packages are well located as version `0.7.0` -> `0.6.0` order. The `0.6.0` packages should be in 3rd page of `INTERPRETER` tab. (Before this commit, I could see some `0.6.0` of package in the middle of `INTERPRETER` package list.)
FYI
>Actually same problem is in https://zeppelin.apache.org/helium_packages.html. So need to fix it as well
I made a PR for this in #2180 :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@AhyoungRyu pagination DOM should be located outside of `ng-repeat` for helium containers.
<img width="832" alt="screen shot 2017-03-27 at 3 41 25 pm" src="https://cloud.githubusercontent.com/assets/4968473/24344271/9e910240-1305-11e7-86f1-51438b9a76c3.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@AhyoungRyu Yes, it would be great to hide unnecessary things
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/2174
[ZEPELIN-2209] Add pagination to Helium menu
### What is this PR for?
Like I did in #2126, added pagination to Helium menu in Zeppelin.
10 pkgs will be shown per 1 page.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2209](https://issues.apache.org/jira/browse/ZEPPELIN-2209)
### How should this be tested?
1. Replace temporarily [ZeppelinConfiguration.java#L46](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L46) with [this url](https://raw.githubusercontent.com/AhyoungRyu/spark-notebook-example/master/helium.json)
2. Build \w below command and restart Zeppelin server
```
$ mvn clean package -DskipTests -pl 'zeppelin-zengine, zeppelin-server, zeppelin-interpreter'
```
3. Start web dev server under `ZEPPELIN_HOME/zeppelin-web` and browse `localhost:9000`
```
$ yarn run dev
```
4. Go to Helium menu -> Click `INTERPRETER` btn
(Currently the other types of pkg are registered in online registry less than 10. That's why I request to change online registry URI in step 1)
5. Check the pagination works well or not
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin add/paginationToHeliumMenu
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2174
----
commit 050b1dc8d32b2248f285c14e80d23061d2ae5419
Author: RyuAhyoung <ah...@macbook-pro-5.local>
Date: 2017-03-22T04:35:41Z
Add pagination to Helium menu
commit e0bb52a53b0012cab9c866fc72e7aec7a6506cb4
Author: RyuAhyoung <ah...@macbook-pro-5.local>
Date: 2017-03-23T06:50:57Z
Fix pkg orderBy published
commit af3f797919cc4b8383dd9bd55dce2f3ce4585d6e
Author: RyuAhyoung <ah...@macbook-pro-5.local>
Date: 2017-03-25T04:03:33Z
Resolve confilct manually
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@AhyoungRyu sure!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda Just noticed that `orderBy: publishedDate` doesn't work well properly now. Let me updated again and will let you know when it's resolved. (Actually same problem is in https://zeppelin.apache.org/helium_packages.html. So need to fix it as well..\U0001f605)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda Thanks for the detailed explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda Thanks!
Will merge into master if there are no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@AhyoungRyu Sorry for confusing. It works as described. maybe i mixed commits \U0001f61e
- It would be nice if we hide `<<` and `>>` when users don't need it. (e.g less than 5 pages)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2174
could this auto scale by screen resolutions? I have seen a lot of cases (a lot of times in presentations/presenting in meeting where projector resolution is low)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---