You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/12/18 02:05:48 UTC

[GitHub] codecov-io commented on issue #4185: recreate http client on resume()

codecov-io commented on issue #4185: recreate http client on resume()
URL: https://github.com/apache/incubator-openwhisk/pull/4185#issuecomment-448069584
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185?src=pr&el=h1) Report
   > Merging [#4185](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/1686a8519a7bcb9d94585c1858fd32795f7f1053?src=pr&el=desc) will **increase** coverage by `20.83%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #4185       +/-   ##
   ===========================================
   + Coverage   60.55%   81.39%   +20.83%     
   ===========================================
     Files         152      152               
     Lines        7292     7283        -9     
     Branches      472      474        +2     
   ===========================================
   + Hits         4416     5928     +1512     
   + Misses       2876     1355     -1521
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...la/org/apache/openwhisk/core/mesos/MesosTask.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbWVzb3MvTWVzb3NUYXNrLnNjYWxh) | `72.09% <0%> (+72.09%)` | :arrow_up: |
   | [...sk/core/containerpool/docker/DockerContainer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyLnNjYWxh) | `96.2% <100%> (+5.06%)` | :arrow_up: |
   | [...containerpool/kubernetes/KubernetesContainer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXIuc2NhbGE=) | `94.73% <100%> (+94.73%)` | :arrow_up: |
   | [...pache/openwhisk/core/containerpool/Container.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXIuc2NhbGE=) | `87.17% <83.33%> (+5.48%)` | :arrow_up: |
   | [...e/openwhisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `92.62% <0%> (+1.63%)` | :arrow_up: |
   | [.../scala/org/apache/openwhisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `85% <0%> (+1.66%)` | :arrow_up: |
   | [.../org/apache/openwhisk/core/entity/EntityPath.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0VudGl0eVBhdGguc2NhbGE=) | `100% <0%> (+1.88%)` | :arrow_up: |
   | [...a/org/apache/openwhisk/core/entity/Parameter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlci5zY2FsYQ==) | `95.45% <0%> (+2.27%)` | :arrow_up: |
   | [.../org/apache/openwhisk/http/PoolingRestClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvUG9vbGluZ1Jlc3RDbGllbnQuc2NhbGE=) | `90% <0%> (+3.33%)` | :arrow_up: |
   | [...hisk/core/controller/actions/SequenceActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1NlcXVlbmNlQWN0aW9ucy5zY2FsYQ==) | `92.1% <0%> (+3.5%)` | :arrow_up: |
   | ... and [92 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185?src=pr&el=footer). Last update [1686a85...d83124d](https://codecov.io/gh/apache/incubator-openwhisk/pull/4185?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services