Would gerrit help to organize accumulo code reviews?

[David Medinets <da...@gmail.com>]

http://code.google.com/p/gerrit/

Re: Would gerrit help to organize accumulo code reviews?

[Joey Echeverria <jo...@cloudera.com>]

I love code reviews :)




At cloudera, we started using Gerrit for a couple of projects and it's been great so far. In particular, it has great git integration.




You can submit a review by just pushing to a special branch and once the review is done, pushing to trunk is automated. 

—
Sent from Mailbox for iPhone

On Fri, Sep 27, 2013 at 9:41 AM, Bill Havanki <bh...@cloudera.com>
wrote:

> Noob question: are code reviews normally done now?
> I've never used gerrit, but I'd be happy to try it. I've used Crucible in
> the past and liked it.
> On Tue, Sep 24, 2013 at 10:29 PM, David Medinets
> <da...@gmail.com>wrote:
>> http://code.google.com/p/gerrit/
>>

Re: Would gerrit help to organize accumulo code reviews?

[Josh Elser <jo...@gmail.com>]

Somewhat related, it would be cool to get Jenkins reviewing patches that
are attached to issues (HDFS is an example I think).

Im not sure of all the functionality that review board provides, but I'm
all for having a more integrated system (regardless of what the actual tool
is to begin).
On Sep 27, 2013 7:00 AM, "Mike Drob" <md...@mdrob.com> wrote:

> Was about to chime in with reviews.a.o, when I saw Sean beat me to it. It's
> mostly that and patches attached to tickets. Pull requests coming from
> github might also work, but I don't think anybody's tried them yet.
>
>
> On Fri, Sep 27, 2013 at 9:57 AM, Sean Busbey <bu...@cloudera.com> wrote:
>
> > Right now, if they're done they'd use the apache infra provided review
> > board.
> >
> > https://reviews.apache.org/
> >
> > Or devs just trading patches.
> >
> > --
> > Sean
> > On Sep 27, 2013 8:41 AM, "Bill Havanki" <bh...@cloudera.com> wrote:
> >
> > > Noob question: are code reviews normally done now?
> > >
> > > I've never used gerrit, but I'd be happy to try it. I've used Crucible
> in
> > > the past and liked it.
> > >
> > >
> > > On Tue, Sep 24, 2013 at 10:29 PM, David Medinets
> > > <da...@gmail.com>wrote:
> > >
> > > > http://code.google.com/p/gerrit/
> > > >
> > >
> >
>

Re: Would gerrit help to organize accumulo code reviews?

[Mike Drob <md...@mdrob.com>]

Was about to chime in with reviews.a.o, when I saw Sean beat me to it. It's
mostly that and patches attached to tickets. Pull requests coming from
github might also work, but I don't think anybody's tried them yet.


On Fri, Sep 27, 2013 at 9:57 AM, Sean Busbey <bu...@cloudera.com> wrote:

> Right now, if they're done they'd use the apache infra provided review
> board.
>
> https://reviews.apache.org/
>
> Or devs just trading patches.
>
> --
> Sean
> On Sep 27, 2013 8:41 AM, "Bill Havanki" <bh...@cloudera.com> wrote:
>
> > Noob question: are code reviews normally done now?
> >
> > I've never used gerrit, but I'd be happy to try it. I've used Crucible in
> > the past and liked it.
> >
> >
> > On Tue, Sep 24, 2013 at 10:29 PM, David Medinets
> > <da...@gmail.com>wrote:
> >
> > > http://code.google.com/p/gerrit/
> > >
> >
>

Re: Would gerrit help to organize accumulo code reviews?

[Sean Busbey <bu...@cloudera.com>]

Right now, if they're done they'd use the apache infra provided review
board.

https://reviews.apache.org/

Or devs just trading patches.

-- 
Sean
On Sep 27, 2013 8:41 AM, "Bill Havanki" <bh...@cloudera.com> wrote:

> Noob question: are code reviews normally done now?
>
> I've never used gerrit, but I'd be happy to try it. I've used Crucible in
> the past and liked it.
>
>
> On Tue, Sep 24, 2013 at 10:29 PM, David Medinets
> <da...@gmail.com>wrote:
>
> > http://code.google.com/p/gerrit/
> >
>

Re: Would gerrit help to organize accumulo code reviews?

[Bill Havanki <bh...@cloudera.com>]

Noob question: are code reviews normally done now?

I've never used gerrit, but I'd be happy to try it. I've used Crucible in
the past and liked it.


On Tue, Sep 24, 2013 at 10:29 PM, David Medinets
<da...@gmail.com>wrote:

> http://code.google.com/p/gerrit/
>