You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by jiny2 <gi...@git.apache.org> on 2015/12/18 05:46:22 UTC
[GitHub] incubator-hawq pull request: HAWQ-260. Resource manager wrongly ca...
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/198
HAWQ-260. Resource manager wrongly calculates number of vseg
This is a bug.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2/incubator-hawq HAWQ-260
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #198
----
commit 5214324c144f84a02b7dacc24babe45bf94baf8b
Author: YI JIN <yj...@pivotal.io>
Date: 2015-12-18T04:45:36Z
HAWQ-260. Resource manager wrongly calculates number of vseg
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-260. Resource manager wrongly ca...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/198#issuecomment-165672751
The fix looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-260. Resource manager wrongly ca...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-260. Resource manager wrongly ca...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/198#issuecomment-165673998
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-260. Resource manager wrongly ca...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/198#discussion_r47994781
--- Diff: src/backend/resourcemanager/resqueuemanager.c ---
@@ -3384,9 +3384,8 @@ int computeQueryQuota(ConnectionTrack conn, char *errorbuf, int errorbufsize)
*/
if ( conn->MinSegCountFixed != conn->MaxSegCountFixed )
{
- vseglimit = conn->VSegLimit ?
- conn->VSegLimit :
- conn->VSegLimitPerSeg * PRESPOOL->AvailNodeCount;
+ vseglimit = conn->VSegLimitPerSeg * PRESPOOL->AvailNodeCount;
--- End diff --
I'd like to keep original code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-260. Resource manager wrongly ca...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/198#discussion_r47994506
--- Diff: src/backend/resourcemanager/resqueuemanager.c ---
@@ -3384,9 +3384,8 @@ int computeQueryQuota(ConnectionTrack conn, char *errorbuf, int errorbufsize)
*/
if ( conn->MinSegCountFixed != conn->MaxSegCountFixed )
{
- vseglimit = conn->VSegLimit ?
- conn->VSegLimit :
- conn->VSegLimitPerSeg * PRESPOOL->AvailNodeCount;
+ vseglimit = conn->VSegLimitPerSeg * PRESPOOL->AvailNodeCount;
--- End diff --
I would be clearer using below:
vseglimit = min(conn->VsegLimit, (conn->VSegLimitPerSeg) * (PRESPOOL->AvailNodeCount));
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---