You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@fluo.apache.org by gi...@git.apache.org on 2017/06/02 14:45:44 UTC

[GitHub] cjmctague commented on a change in pull request #863: fixes - #833

cjmctague commented on a change in pull request #863: fixes - #833
URL: https://github.com/apache/incubator-fluo/pull/863#discussion_r119874801
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/fluo/core/observer/v1/ObserverStoreV1.java
 ##########
 @@ -161,7 +161,9 @@ private static void serializeObservers(DataOutputStream dos,
   private static Map<Column, ObserverSpecification> readObservers(DataInputStream dis)
       throws IOException {
 
-    HashMap<Column, ObserverSpecification> omap = new HashMap<>();
+    ImmutableMap.Builder<Column, ObserverSpecification> omapBuilder =
+        new ImmutableMap.Builder<Column, ObserverSpecification>();
+    ImmutableMap<Column, ObserverSpecification> omap = ImmutableMap.of();
 
 Review comment:
   Just build in the return statement?
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services