You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/23 13:26:33 UTC

[GitHub] [pulsar] Jason918 opened a new pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Jason918 opened a new pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443


   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
   
   Fixes #11440
   
   ### Motivation
   
   see issue 11440
   
   ### Modifications
   
   Add all the other non-empty meta data fields in http response headers in `org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#generateResponseWithEntry`. For fields with byte[] type, base64 is used for serialization and deserialization.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   
   
   This change added tests and can be verified as follows:
   
   `org.apache.pulsar.broker.admin.PersistentTopicsTest#testExamineMessageMetadata`
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443#issuecomment-886670239


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443#issuecomment-885984006


   @Jason918 Please check the checkstyle issue 
   
   ```
   Error:  src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java:[111,44] (whitespace) WhitespaceAround: '=' is not preceded with whitespace.
   Error:  src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java:[118,37] (whitespace) WhitespaceAround: '=' is not preceded with whitespace.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443#issuecomment-886583024


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie merged pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443#issuecomment-887141963


   > @Jason918 Please check the checkstyle issue
   > 
   > ```
   > Error:  src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java:[111,44] (whitespace) WhitespaceAround: '=' is not preceded with whitespace.
   > Error:  src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java:[118,37] (whitespace) WhitespaceAround: '=' is not preceded with whitespace.
   > ```
   Fixed it. 
   Sorry for that .
   There seems a lot flaky tests lately. @_@


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443#issuecomment-886579195


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443#issuecomment-886400901


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 edited a comment on pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Posted by GitBox <gi...@apache.org>.
Jason918 edited a comment on pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443#issuecomment-887141963


   > @Jason918 Please check the checkstyle issue
   > 
   > ```
   > Error:  src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java:[111,44] (whitespace) WhitespaceAround: '=' is not preceded with whitespace.
   > Error:  src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java:[118,37] (whitespace) WhitespaceAround: '=' is not preceded with whitespace.
   > ```
   @codelipenghui 
   Fixed it. 
   Sorry for that .
   There seems a lot flaky tests lately. @_@


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443#issuecomment-887283082


   @Jason918 thanks for your great work. Would you like to add docs accordingly? Then you can ping me to review, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #11443:
URL: https://github.com/apache/pulsar/pull/11443#issuecomment-887335005


   > @Jason918 thanks for your great work. Would you like to add docs accordingly? Then you can ping me to review, thanks
   
   @Anonymitaet It seems there're no user docs for examine-message cmd. So I added new section for it. Please check it out in my last commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org