You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/02 06:52:57 UTC
[GitHub] [spark] ByronHsu commented on a change in pull request #34466: [SPARK-37152][PYTHON] Inline type hints for python/pyspark/context.py
ByronHsu commented on a change in pull request #34466:
URL: https://github.com/apache/spark/pull/34466#discussion_r740760086
##########
File path: python/pyspark/context.py
##########
@@ -150,8 +161,10 @@ def __init__(self, master=None, appName=None, sparkHome=None, pyFiles=None,
self.stop()
raise
- def _do_init(self, master, appName, sparkHome, pyFiles, environment, batchSize, serializer,
- conf, jsc, profiler_cls):
+ # TODO
Review comment:
@zero323 There are some function that does not exist in .pyi. How can I know the type of the args and return value?
##########
File path: python/pyspark/context.py
##########
@@ -150,8 +161,10 @@ def __init__(self, master=None, appName=None, sparkHome=None, pyFiles=None,
self.stop()
raise
- def _do_init(self, master, appName, sparkHome, pyFiles, environment, batchSize, serializer,
- conf, jsc, profiler_cls):
+ # TODO
Review comment:
@zero323 There are some functions that does not exist in .pyi. How can I know the type of the args and return value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org