You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Fredrik Hedberg (JIRA)" <ji...@apache.org> on 2009/04/09 14:03:13 UTC
[jira] Created: (HADOOP-5649) Enable ServicePlugins for the
JobTracker
Enable ServicePlugins for the JobTracker
----------------------------------------
Key: HADOOP-5649
URL: https://issues.apache.org/jira/browse/HADOOP-5649
Project: Hadoop Core
Issue Type: New Feature
Components: mapred
Reporter: Fredrik Hedberg
Priority: Minor
Attachments: sp-jt-1.diff
Allow ServicePlugins (see HADOOP-5257) for the JobTracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5649) Enable ServicePlugins for the
JobTracker
Posted by "Fredrik Hedberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fredrik Hedberg updated HADOOP-5649:
------------------------------------
Status: Patch Available (was: Open)
> Enable ServicePlugins for the JobTracker
> ----------------------------------------
>
> Key: HADOOP-5649
> URL: https://issues.apache.org/jira/browse/HADOOP-5649
> Project: Hadoop Core
> Issue Type: New Feature
> Components: mapred
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: sp-jt-1.diff
>
>
> Allow ServicePlugins (see HADOOP-5257) for the JobTracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5649) Enable ServicePlugins for the
JobTracker
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715051#action_12715051 ]
Devaraj Das commented on HADOOP-5649:
-------------------------------------
Could you please write a unit test for this? Thanks!
> Enable ServicePlugins for the JobTracker
> ----------------------------------------
>
> Key: HADOOP-5649
> URL: https://issues.apache.org/jira/browse/HADOOP-5649
> Project: Hadoop Core
> Issue Type: New Feature
> Components: mapred
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: sp-jt-1.diff
>
>
> Allow ServicePlugins (see HADOOP-5257) for the JobTracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5649) Enable ServicePlugins for the
JobTracker
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697707#action_12697707 ]
Hadoop QA commented on HADOOP-5649:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12405064/sp-jt-1.diff
against trunk revision 763728.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/176/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/176/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/176/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/176/console
This message is automatically generated.
> Enable ServicePlugins for the JobTracker
> ----------------------------------------
>
> Key: HADOOP-5649
> URL: https://issues.apache.org/jira/browse/HADOOP-5649
> Project: Hadoop Core
> Issue Type: New Feature
> Components: mapred
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: sp-jt-1.diff
>
>
> Allow ServicePlugins (see HADOOP-5257) for the JobTracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5649) Enable ServicePlugins for the
JobTracker
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713486#action_12713486 ]
Amar Kamat commented on HADOOP-5649:
------------------------------------
Fredrik, the patch looks good. Few minor comments.
# Can you add 'mapred.jobtracker.plugins' to mapred-default.xml and document it there.
# bq. LOG.warn("ServicePlugin " + p + " could not be started", t);
and
bq. LOG.warn("ServicePlugin " + p + " could not be stopped", t);
Here *p* will log junk info about the object (Object.toString()). Either we can simply dump the exception or else define {{ServicePlugin.getName()}}.
Rest looks good.
> Enable ServicePlugins for the JobTracker
> ----------------------------------------
>
> Key: HADOOP-5649
> URL: https://issues.apache.org/jira/browse/HADOOP-5649
> Project: Hadoop Core
> Issue Type: New Feature
> Components: mapred
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: sp-jt-1.diff
>
>
> Allow ServicePlugins (see HADOOP-5257) for the JobTracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5649) Enable ServicePlugins for the
JobTracker
Posted by "Fredrik Hedberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697794#action_12697794 ]
Fredrik Hedberg commented on HADOOP-5649:
-----------------------------------------
AFAIK, the failed tests are not related to this issue. I don't think this patch warrants any new unit tests.
> Enable ServicePlugins for the JobTracker
> ----------------------------------------
>
> Key: HADOOP-5649
> URL: https://issues.apache.org/jira/browse/HADOOP-5649
> Project: Hadoop Core
> Issue Type: New Feature
> Components: mapred
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: sp-jt-1.diff
>
>
> Allow ServicePlugins (see HADOOP-5257) for the JobTracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5649) Enable ServicePlugins for the
JobTracker
Posted by "Fredrik Hedberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fredrik Hedberg updated HADOOP-5649:
------------------------------------
Attachment: sp-jt-1.diff
> Enable ServicePlugins for the JobTracker
> ----------------------------------------
>
> Key: HADOOP-5649
> URL: https://issues.apache.org/jira/browse/HADOOP-5649
> Project: Hadoop Core
> Issue Type: New Feature
> Components: mapred
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: sp-jt-1.diff
>
>
> Allow ServicePlugins (see HADOOP-5257) for the JobTracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.