You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/22 11:56:36 UTC

[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #12955: ARROW-16240: [Python] Support row_group_size/chunk_size keyword in pq.write_to_dataset with use_legacy_dataset=False

jorisvandenbossche commented on code in PR #12955:
URL: https://github.com/apache/arrow/pull/12955#discussion_r856157482


##########
python/pyarrow/parquet/__init__.py:
##########
@@ -3049,6 +3049,7 @@ def file_visitor(written_file):
         # extract non-file format options
         schema = kwargs.pop("schema", None)
         use_threads = kwargs.pop("use_threads", True)
+        chunk_size = kwargs.pop("chunk_size", None)

Review Comment:
   Can you also catch `row_group_size`, as that is the documented keyword in `write_table` (it keeps `chunk_size` as an alias through `row_group_size = kwargs.pop('chunk_size', row_group_size)` inside `write_table`.
   Probably giving precedence to `row_group_size` over `chunksize`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org