You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by anubhav100 <gi...@git.apache.org> on 2017/12/22 12:31:17 UTC
[GitHub] carbondata pull request #1719: [CARBONDATA-1731,CARBONDATA-1728] Update fail...
GitHub user anubhav100 opened a pull request:
https://github.com/apache/carbondata/pull/1719
[CARBONDATA-1731,CARBONDATA-1728] Update fails incorrectly with error
[QueryExecution] Fetch BlockletId in Executor. Currently the granular…These blockletId are not propagated to the excutrs properly. Due to this reason the Implicit columns i.e. tupleId formed in executers can wrongly form duplicate tupleId. For e.g. a Block having two blocklets i.e. 0 and 1, in executors each tasks picks each blocklets. As the ID is not propagated each executor will term the Blocklets as ID 0. Solution is to propagate the Blocklet IDs to the executor from driver
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-1731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1719.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1719
----
commit 9b53188a57395ffecd99e33309df2b9b874a21ac
Author: anubhav100 <an...@...>
Date: 2017-12-14T07:24:08Z
Update fails incorrectly with error for table created in external db location
commit a9f64729fcecc4bea1e995a4bd187f4442a16e27
Author: anubhav100 <an...@...>
Date: 2017-12-22T12:23:26Z
[QueryExecution] Fetch BlockletId in Executor. Currently the granular…These blockletId are not propagated to the excutrs properly. Due to this reason the Implicit columns i.e. tupleId formed
in executers can wrongly form duplicate tupleId. For e.g. a Block having two blocklets i.e. 0 and 1, in executors each
tasks picks each blocklets. As the ID is not propagated each executor will term the Blocklets as ID 0.
Solution is to propagate the Blocklet IDs to the executor from driver
----
---
[GitHub] carbondata issue #1719: [CARBONDATA-1731,CARBONDATA-1728] Update,Delete fail...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1719
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1087/
---
[GitHub] carbondata issue #1719: [WIP] [CARBONDATA-1731,CARBONDATA-1728] Update fails...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1719
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2275/
---
[GitHub] carbondata issue #1719: [CARBONDATA-1731,CARBONDATA-1728] Update,Delete fail...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1719
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1089/
---
[GitHub] carbondata issue #1719: [CARBONDATA-1731,CARBONDATA-1728] Update,Delete fail...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1719
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2541/
---
[GitHub] carbondata pull request #1719: [WIP] [CARBONDATA-1731,CARBONDATA-1728] Updat...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1719#discussion_r158507995
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/TableBlockInfo.java ---
@@ -113,10 +120,29 @@ public TableBlockInfo() {
public TableBlockInfo(String filePath, long blockOffset, String segmentId, String[] locations,
long blockLength, BlockletInfos blockletInfos, ColumnarFormatVersion version,
String[] deletedDeltaFilePath) {
- this(filePath, blockOffset, segmentId, locations, blockLength, version, deletedDeltaFilePath);
+ this(filePath, blockOffset, segmentId, locations, blockLength, version,
+ deletedDeltaFilePath);
this.blockletInfos = blockletInfos;
}
+ /**
+ * constructor to initialize the TbaleBlockInfo with blockletIds
+ *
+ * @param filePath
+ * @param blockOffset
+ * @param segmentId
+ * @param locations
+ * @param blockLength
+ * @param blockletInfos
+ */
+ public TableBlockInfo(String filePath, String blockletIds, long blockOffset, String segmentId,
--- End diff --
corrected
---
[GitHub] carbondata issue #1719: [WIP] [CARBONDATA-1731,CARBONDATA-1728] Update fails...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1719
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2524/
---
[GitHub] carbondata issue #1719: [CARBONDATA-1731,CARBONDATA-1728] Update,Delete fail...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/1719
retest this please
---
[GitHub] carbondata issue #1719: [CARBONDATA-1731,CARBONDATA-1728] Update,Delete fail...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1719
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2305/
---
[GitHub] carbondata issue #1719: [CARBONDATA-1731,CARBONDATA-1728] Update,Delete fail...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1719
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2303/
---
[GitHub] carbondata issue #1719: [CARBONDATA-1731,CARBONDATA-1728] Update,Delete fail...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1719
LGTM
---
[GitHub] carbondata pull request #1719: [WIP] [CARBONDATA-1731,CARBONDATA-1728] Updat...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1719#discussion_r158504977
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/TableBlockInfo.java ---
@@ -113,10 +120,29 @@ public TableBlockInfo() {
public TableBlockInfo(String filePath, long blockOffset, String segmentId, String[] locations,
long blockLength, BlockletInfos blockletInfos, ColumnarFormatVersion version,
String[] deletedDeltaFilePath) {
- this(filePath, blockOffset, segmentId, locations, blockLength, version, deletedDeltaFilePath);
+ this(filePath, blockOffset, segmentId, locations, blockLength, version,
+ deletedDeltaFilePath);
this.blockletInfos = blockletInfos;
}
+ /**
+ * constructor to initialize the TbaleBlockInfo with blockletIds
+ *
+ * @param filePath
+ * @param blockOffset
+ * @param segmentId
+ * @param locations
+ * @param blockLength
+ * @param blockletInfos
+ */
+ public TableBlockInfo(String filePath, String blockletIds, long blockOffset, String segmentId,
--- End diff --
typo blockletId
---
[GitHub] carbondata issue #1719: [CARBONDATA-1731,CARBONDATA-1728] Update,Delete fail...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1719
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2542/
---
[GitHub] carbondata issue #1719: [WIP] [CARBONDATA-1731,CARBONDATA-1728] Update fails...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1719
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2522/
---
[GitHub] carbondata issue #1719: [WIP] [CARBONDATA-1731,CARBONDATA-1728] Update fails...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1719
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1054/
---
[GitHub] carbondata pull request #1719: [CARBONDATA-1731,CARBONDATA-1728] Update,Dele...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1719
---