You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2015/10/18 17:10:44 UTC

Fwd: logging-log4j2 git commit: LOG4J2-1166 AbstractConfiguration executor should use a DaemonThreadFactory.

Good one!

Gary

---------- Forwarded message ----------
From: <rp...@apache.org>
Date: Sun, Oct 18, 2015 at 5:12 AM
Subject: logging-log4j2 git commit: LOG4J2-1166 AbstractConfiguration
executor should use a DaemonThreadFactory.
To: commits@logging.apache.org


Repository: logging-log4j2
Updated Branches:
  refs/heads/master 2341b29f2 -> d2747d6bd


LOG4J2-1166 AbstractConfiguration executor should use a
DaemonThreadFactory.


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit:
http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/d2747d6b
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/d2747d6b
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/d2747d6b

Branch: refs/heads/master
Commit: d2747d6bd188dcb34acf4db9102f98ecbed4e094
Parents: 2341b29
Author: rpopma <rp...@apache.org>
Authored: Sun Oct 18 21:12:47 2015 +0900
Committer: rpopma <rp...@apache.org>
Committed: Sun Oct 18 21:12:47 2015 +0900

----------------------------------------------------------------------
 .../apache/logging/log4j/core/config/AbstractConfiguration.java | 3 ++-
 src/changes/changes.xml                                         | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d2747d6b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
----------------------------------------------------------------------
diff --git
a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
index 5ae381e..d5ea071 100644
---
a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
+++
b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
@@ -45,6 +45,7 @@ import
org.apache.logging.log4j.core.appender.AsyncAppender;
 import org.apache.logging.log4j.core.appender.ConsoleAppender;
 import org.apache.logging.log4j.core.async.AsyncLoggerConfig;
 import org.apache.logging.log4j.core.async.AsyncLoggerContextSelector;
+import org.apache.logging.log4j.core.async.DaemonThreadFactory;
 import org.apache.logging.log4j.core.config.plugins.util.PluginBuilder;
 import org.apache.logging.log4j.core.config.plugins.util.PluginManager;
 import org.apache.logging.log4j.core.config.plugins.util.PluginType;
@@ -173,7 +174,7 @@ public abstract class AbstractConfiguration extends
AbstractFilterable implement
     public void initialize() {
         LOGGER.debug("Initializing configuration {}", this);
         if (watchManager.getIntervalSeconds() > 0) {
-            executorService = new ScheduledThreadPoolExecutor(1);
+            executorService = new ScheduledThreadPoolExecutor(1, new
DaemonThreadFactory("Log4j2ConfigWatcher-"));
             watchManager.setExecutorService(executorService);
         }
         scriptManager = new ScriptManager(watchManager);

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d2747d6b/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index ba64019..221ebdc 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -24,6 +24,9 @@
   </properties>
   <body>
     <release version="2.5" date="2015-MM-DD" description="GA Release 2.5">
+      <action issue="LOG4J2-1166" dev="rpopma" type="fix">
+        AbstractConfiguration executor should use a DaemonThreadFactory.
+      </action>
       <action issue="LOG4J2-1165" dev="rpopma" type="fix">
         Reduce verbosity of Log4j initialization status messages.
       </action>
@@ -185,7 +188,7 @@
       <action issue="LOG4J2-1106" dev="ggregory" type="add" due-to="Gary
Gregory">
         Add a LevelRangeFilter class.
       </action>
-      <action issue="LOG4J2-1076" dev="rpopma" type="add">
+      <action issue="LOG4J2-1074" dev="rpopma" type="add">
         Added support for system nanosecond time in pattern layout.
       </action>
       <action issue="LOG4J2-1075" dev="rpopma" type="add">




-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory