You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/24 09:50:54 UTC

[GitHub] [thrift] zeshuai007 opened a new pull request #2117: Supplement TBinaryprotocol module testcase

zeshuai007 opened a new pull request #2117:
URL: https://github.com/apache/thrift/pull/2117


   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] zeshuai007 commented on pull request #2117: Supplement TBinaryprotocol module testcase

Posted by GitBox <gi...@apache.org>.
zeshuai007 commented on pull request #2117:
URL: https://github.com/apache/thrift/pull/2117#issuecomment-619790668


   @dcelasun , I have modified it, and the CI has passed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun commented on pull request #2117: Supplement TBinaryprotocol module testcase

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2117:
URL: https://github.com/apache/thrift/pull/2117#issuecomment-619798847


   @zeshuai007 thanks, merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun commented on pull request #2117: Supplement TBinaryprotocol module testcase

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2117:
URL: https://github.com/apache/thrift/pull/2117#issuecomment-619344705


   Tests are failing:
   ```
   # Python code style
   flake8
   ./lib/py/test/thrift_TBinaryProtocol.py:1:1: F401 'sys' imported but unused
   ./lib/py/test/thrift_TBinaryProtocol.py:9:19: E231 missing whitespace after ','
   ./lib/py/test/thrift_TBinaryProtocol.py:13:25: E221 multiple spaces before operator
   ./lib/py/test/thrift_TBinaryProtocol.py:38:28: W291 trailing whitespace
   ./lib/py/test/thrift_TBinaryProtocol.py:66:1: E302 expected 2 blank lines, found 1
   ./lib/py/test/thrift_TBinaryProtocol.py:66:19: E231 missing whitespace after ','
   ./lib/py/test/thrift_TBinaryProtocol.py:72:37: E231 missing whitespace after ','
   ./lib/py/test/thrift_TBinaryProtocol.py:72:62: E231 missing whitespace after ','
   ./lib/py/test/thrift_TBinaryProtocol.py:73:25: E221 multiple spaces before operator
   ./lib/py/test/thrift_TBinaryProtocol.py:108:25: E221 multiple spaces before operator
   ./lib/py/test/thrift_TBinaryProtocol.py:135:1: E302 expected 2 blank lines, found 1
   ./lib/py/test/thrift_TBinaryProtocol.py:136:12: E225 missing whitespace around operator
   ./lib/py/test/thrift_TBinaryProtocol.py:220:25: E128 continuation line under-indented for visual indent
   ./lib/py/test/thrift_TBinaryProtocol.py:221:25: E128 continuation line under-indented for visual indent
   ./lib/py/test/thrift_TBinaryProtocol.py:222:25: E128 continuation line under-indented for visual indent
   ./lib/py/test/thrift_TBinaryProtocol.py:223:25: E128 continuation line under-indented for visual indent
   ./lib/py/test/thrift_TBinaryProtocol.py:227:43: E231 missing whitespace after ','
   ./lib/py/test/thrift_TBinaryProtocol.py:228:43: E231 missing whitespace after ','
   ./lib/py/test/thrift_TBinaryProtocol.py:229:43: E231 missing whitespace after ','
   ./lib/py/test/thrift_TBinaryProtocol.py:231:30: E203 whitespace before ':'
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org