You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/09 19:03:50 UTC

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #720: [optimize] Stop batchFlushTicker when Disable batching

cckellogg commented on a change in pull request #720:
URL: https://github.com/apache/pulsar-client-go/pull/720#discussion_r802997548



##########
File path: pulsar/producer_partition.go
##########
@@ -126,6 +126,9 @@ func newPartitionProducer(client *client, topic string, options *ProducerOptions
 		metrics:          metrics,
 		epoch:            0,
 	}
+	if p.options.DisableBatching {
+		p.batchFlushTicker.Stop()

Review comment:
       Is it ok to call Stop() multiple times? There is a call to stop in the internal close.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org