You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/05 02:09:53 UTC
[GitHub] [arrow-datafusion] jychen7 opened a new pull request, #2159: #2109 schema infer max
jychen7 opened a new pull request, #2159:
URL: https://github.com/apache/arrow-datafusion/pull/2159
# Which issue does this PR close?
patch v7.x with #2109
was merged to `master` at https://github.com/apache/arrow-datafusion/pull/2139
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jychen7 commented on pull request #2159: #2109 schema infer max
Posted by GitBox <gi...@apache.org>.
jychen7 commented on PR #2159:
URL: https://github.com/apache/arrow-datafusion/pull/2159#issuecomment-1088750729
the clippy error impact quite a few files, would be better we resolve in new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jychen7 commented on pull request #2159: #2109 schema infer max
Posted by GitBox <gi...@apache.org>.
jychen7 commented on PR #2159:
URL: https://github.com/apache/arrow-datafusion/pull/2159#issuecomment-1089629379
> the clippy error impact quite a few files, would be better we resolve in new PR
https://github.com/apache/arrow-datafusion/pull/2166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2159: #2109 schema infer max
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2159:
URL: https://github.com/apache/arrow-datafusion/pull/2159#issuecomment-1088752099
> the clippy error impact quite a few files, would be better we resolve in new PR
I agree -- merged this one in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2159: #2109 schema infer max
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2159:
URL: https://github.com/apache/arrow-datafusion/pull/2159#issuecomment-1088545050
Looks like there are some other clippy errors left on the maint branch -- if you want we can merge this PR in as is and then we can fix the clippy errors on the maint branch as a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2159: #2109 schema infer max
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2159:
URL: https://github.com/apache/arrow-datafusion/pull/2159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jychen7 commented on a diff in pull request #2159: #2109 schema infer max
Posted by GitBox <gi...@apache.org>.
jychen7 commented on code in PR #2159:
URL: https://github.com/apache/arrow-datafusion/pull/2159#discussion_r842290217
##########
datafusion/fuzz-utils/src/lib.rs:
##########
@@ -26,7 +26,7 @@ pub use env_logger;
pub fn batches_to_vec(batches: &[RecordBatch]) -> Vec<Option<i32>> {
batches
.iter()
- .map(|batch| {
+ .flat_map(|batch| {
Review Comment:
same fix as https://github.com/apache/arrow-datafusion/pull/1885/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org