You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Olivier Croisier (JIRA)" <ji...@apache.org> on 2009/11/11 15:27:39 UTC

[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Attachment: RuntimeConfigurationTypesEnum.patch

Here is a full patch converting the configuration types into a type-safe Enum.
Covers all the Wicket codebase as of revision 832322.

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.