You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/27 21:53:02 UTC
[GitHub] [incubator-superset] graceguo-supercat commented on a change in
pull request #8305: [SQL Lab] Improve autocomplete
graceguo-supercat commented on a change in pull request #8305: [SQL Lab] Improve autocomplete
URL: https://github.com/apache/incubator-superset/pull/8305#discussion_r329253575
##########
File path: superset/assets/src/SqlLab/components/AceEditorWrapper.jsx
##########
@@ -27,6 +27,11 @@ import { areArraysShallowEqual } from '../../reduxUtils';
const langTools = ace.acequire('ace/ext/language_tools');
+const SQL_KEYWORD_AUTOCOMPLETE_SCORE = 100;
Review comment:
where are those `score: XXXXX_ SCORE` used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org