You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/17 15:17:56 UTC
[GitHub] [apisix-dashboard] liuyang211 opened a new pull request #1477: support etcd prefix as apisix does
liuyang211 opened a new pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [*] New feature provided
- Related issues
Fixes #1456
___
### New feature or improvement
- Describe the details and related test reports.
support etcd prefix as apisix does
___
### Please add the corresponding test cases if necessary.
___
### Backport patches
- Why need to backport?
- Source branch
- Related commits and pull requests
- Target branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuyang211 edited a comment on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
liuyang211 edited a comment on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-784277090
> @liuyang211
> The reason for the failure is that there is no sleep after the previous stop, which causes the Manager API to not really restart successfully:
> https://github.com/apache/apisix-dashboard/pull/1477/checks?check_run_id=1946779863#step:5:530
Thanks, the testcase is OK now.
I'll add more testcases for routes, services, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-785542004
@liuyang211
More contributions are welcome ! : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-781442602
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=h1) Report
> Merging [#1477](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=desc) (901b399) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `17.32%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1477 +/- ##
===========================================
- Coverage 68.95% 51.63% -17.33%
===========================================
Files 48 39 -9
Lines 3038 2597 -441
===========================================
- Hits 2095 1341 -754
- Misses 705 1082 +377
+ Partials 238 174 -64
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.49%)` | :arrow_down: |
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=footer). Last update [bd5ed03...901b399](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-783774501
@liuyang211
The reason for the failure is that there is no sleep after the previous stop, which causes the Manager API to not really restart successfully:
https://github.com/apache/apisix-dashboard/pull/1477/checks?check_run_id=1946779863#step:5:530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-784857817
@liuyang211
merged. thanks a lot !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-781442602
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=h1) Report
> Merging [#1477](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=desc) (7cf7a7c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/20d549255d8d835e5838587eafff6bd91f52f497?el=desc) (20d5492) will **decrease** coverage by `0.25%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1477 +/- ##
==========================================
- Coverage 68.89% 68.63% -0.26%
==========================================
Files 48 48
Lines 3038 3042 +4
==========================================
- Hits 2093 2088 -5
- Misses 707 714 +7
- Partials 238 240 +2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `70.96% <60.00%> (-1.45%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `70.40% <100.00%> (-4.09%)` | :arrow_down: |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (-3.64%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.34% <0.00%> (+0.60%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=footer). Last update [20d5492...7cf7a7c](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuyang211 commented on a change in pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
liuyang211 commented on a change in pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#discussion_r579613950
##########
File path: api/internal/conf/conf.go
##########
@@ -225,10 +226,16 @@ func initEtcdConfig(conf Etcd) {
endpoints = conf.Endpoints
}
+ var prefix = "/apisix"
Review comment:
OK, I'll change it this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-781749631
@liuyang211 need some test cases. please refer to https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L300-L327
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-783710278
cc @nic-chen to take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuyang211 commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
liuyang211 commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-782577827
> @liuyang211 need some test cases. please refer to https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L300-L327
> thanks.
I run these cmds to test it locally,
```shell
cd apisix-dashboard/api
./test/shell/cli_test.sh
```
but fail at
`
./test/shell/cli_test.sh: line 347: ./etcd-v3.4.14-linux-amd64/etcd: No such file or directory
`
Do I miss something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-781442602
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=h1) Report
> Merging [#1477](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=desc) (7cf7a7c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/20d549255d8d835e5838587eafff6bd91f52f497?el=desc) (20d5492) will **decrease** coverage by `46.31%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1477 +/- ##
===========================================
- Coverage 68.89% 22.58% -46.32%
===========================================
Files 48 48
Lines 3038 3042 +4
===========================================
- Hits 2093 687 -1406
- Misses 707 2214 +1507
+ Partials 238 141 -97
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `70.96% <60.00%> (-1.45%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `45.91% <100.00%> (-28.58%)` | :arrow_down: |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: |
| [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `8.91% <0.00%> (-72.28%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `21.27% <0.00%> (-70.22%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.56% <0.00%> (-68.23%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=footer). Last update [20d5492...7cf7a7c](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-781442602
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=h1) Report
> Merging [#1477](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=desc) (36e00cd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/20d549255d8d835e5838587eafff6bd91f52f497?el=desc) (20d5492) will **decrease** coverage by `45.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1477 +/- ##
===========================================
- Coverage 68.89% 23.27% -45.62%
===========================================
Files 48 48
Lines 3038 3042 +4
===========================================
- Hits 2093 708 -1385
- Misses 707 2192 +1485
+ Partials 238 142 -96
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `74.19% <100.00%> (+1.77%)` | :arrow_up: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `50.00% <100.00%> (-24.49%)` | :arrow_down: |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: |
| [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `8.91% <0.00%> (-72.28%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `21.27% <0.00%> (-70.22%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.56% <0.00%> (-68.23%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=footer). Last update [20d5492...36e00cd](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuyang211 commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
liuyang211 commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-784277090
> @liuyang211
> The reason for the failure is that there is no sleep after the previous stop, which causes the Manager API to not really restart successfully:
> https://github.com/apache/apisix-dashboard/pull/1477/checks?check_run_id=1946779863#step:5:530
Thanks, the testcase is OK now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-781442602
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=h1) Report
> Merging [#1477](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=desc) (36e00cd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/20d549255d8d835e5838587eafff6bd91f52f497?el=desc) (20d5492) will **decrease** coverage by `13.43%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1477 +/- ##
===========================================
- Coverage 68.89% 55.45% -13.44%
===========================================
Files 48 48
Lines 3038 3042 +4
===========================================
- Hits 2093 1687 -406
- Misses 707 1073 +366
- Partials 238 282 +44
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `74.19% <100.00%> (+1.77%)` | :arrow_up: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `74.48% <100.00%> (ø)` | |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `54.25% <0.00%> (-37.24%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `34.69% <0.00%> (-34.19%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=footer). Last update [20d5492...36e00cd](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#discussion_r578863638
##########
File path: api/internal/conf/conf.go
##########
@@ -225,10 +226,16 @@ func initEtcdConfig(conf Etcd) {
endpoints = conf.Endpoints
}
+ var prefix = "/apisix"
Review comment:
Use short assignment is better:
```
prefix := "/apisix"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-781442602
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=h1) Report
> Merging [#1477](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=desc) (7cf7a7c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/20d549255d8d835e5838587eafff6bd91f52f497?el=desc) (20d5492) will **decrease** coverage by `13.79%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1477 +/- ##
===========================================
- Coverage 68.89% 55.09% -13.80%
===========================================
Files 48 48
Lines 3038 3042 +4
===========================================
- Hits 2093 1676 -417
- Misses 707 1084 +377
- Partials 238 282 +44
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `70.96% <60.00%> (-1.45%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `70.40% <100.00%> (-4.09%)` | :arrow_down: |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `54.25% <0.00%> (-37.24%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `34.69% <0.00%> (-34.19%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=footer). Last update [20d5492...7cf7a7c](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuyang211 edited a comment on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
liuyang211 edited a comment on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-782577827
> @liuyang211 need some test cases. please refer to https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L300-L327
> thanks.
I run these cmds to test it locally,
```shell
cd apisix-dashboard/api
./test/shell/cli_test.sh
```
but fail at
`
./test/shell/cli_test.sh: line 347: ./etcd-v3.4.14-linux-amd64/etcd: No such file or directory
`
Do I miss something?
BTW
1. /tmp/manager-api is used as both directory and file.
https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L143-L144
https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L166
This seems to raise this error if `rm /tmp/manager-api` is not manually excuted before next test.
`cp: cannot overwrite non-directory '/tmp/manager-api' with directory '/home/newbie/dev/apisix-dashboard/api'`
2. These two lines should swap to avoid error message when stopping manager-api
https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L385-L387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
starsz commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-780978036
Can you write some test cases at "/api/test/shell/cli_test.sh" to test this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuyang211 commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
liuyang211 commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-785110136
> @liuyang211
> merged. thanks a lot !
Thank you for your help!
@nic-chen @juzhiyuan @starsz @tokers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-780869434
Hi, I see there have 3 checks failed:
- Backend CLI & Backend E2E: @nic-chen will help you to check what happened.
- Semantic Pull Request: You could ignore safely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-780869434
Hi, I see there have 3 checks failed:
- Backend CLI & Backend E2E: @nic-chen will help you to check what happened.
- Semantic Pull Request: You could ignore it safely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuyang211 commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
liuyang211 commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-783490790
> @liuyang211
> please have a look at https://github.com/apache/apisix-dashboard/blob/master/.github/workflows/backend-cli-test.yml#L27-L31
>
> If there is something not good, you could fix it. thanks.
Hi, the testcase runs OK in my local machine, but fails in the github workflow, could you review my testcase and give some advice? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#discussion_r580685851
##########
File path: api/test/shell/cli_test.sh
##########
@@ -343,6 +343,75 @@ check_logfile
./manager-api stop
Review comment:
need to sleep after stop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-782790672
@liuyang211
please have a look at https://github.com/apache/apisix-dashboard/blob/master/.github/workflows/backend-cli-test.yml#L27-L31
If there is something not good, you could fix it. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-781442602
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=h1) Report
> Merging [#1477](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=desc) (acd9cf6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/20d549255d8d835e5838587eafff6bd91f52f497?el=desc) (20d5492) will **decrease** coverage by `13.86%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1477 +/- ##
===========================================
- Coverage 68.89% 55.02% -13.87%
===========================================
Files 48 48
Lines 3038 3042 +4
===========================================
- Hits 2093 1674 -419
- Misses 707 1091 +384
- Partials 238 277 +39
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `70.96% <60.00%> (-1.45%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `74.48% <100.00%> (ø)` | |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `54.25% <0.00%> (-37.24%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `34.69% <0.00%> (-34.19%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1477/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=footer). Last update [20d5492...acd9cf6](https://codecov.io/gh/apache/apisix-dashboard/pull/1477?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1477: feat: support etcd prefix as apisix does
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-781034683
Hi, please sync your codes with the master branch to fix the CI failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org