You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by as...@apache.org on 2021/03/19 15:06:11 UTC

[airflow] 09/42: Log migrations info in consistent way (#14158)

This is an automated email from the ASF dual-hosted git repository.

ash pushed a commit to branch v2-0-test
in repository https://gitbox.apache.org/repos/asf/airflow.git

commit 76be86e12a435d68eb7fbe4d69ab5e8a3be40cb7
Author: Kaxil Naik <ka...@gmail.com>
AuthorDate: Wed Feb 10 17:22:52 2021 +0000

    Log migrations info in consistent way (#14158)
    
    same as #13458 but for `82b7c48c147f_remove_can_read_permission_on_config_.py` migration
    
    This migration changes logging handlers
    so each next migration is differently formatted when doing
    airflow db reset. This commit fixes this behavior.
    
    (cherry picked from commit e423e3873f6752fd27f4361e56afca3b12f82d68)
---
 .../versions/82b7c48c147f_remove_can_read_permission_on_config_.py  | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/airflow/migrations/versions/82b7c48c147f_remove_can_read_permission_on_config_.py b/airflow/migrations/versions/82b7c48c147f_remove_can_read_permission_on_config_.py
index 5e85ee4..85d0872 100644
--- a/airflow/migrations/versions/82b7c48c147f_remove_can_read_permission_on_config_.py
+++ b/airflow/migrations/versions/82b7c48c147f_remove_can_read_permission_on_config_.py
@@ -23,6 +23,7 @@ Revises: e959f08ac86c
 Create Date: 2021-02-04 12:45:58.138224
 
 """
+import logging
 
 from airflow.security import permissions
 from airflow.www.app import create_app
@@ -36,6 +37,9 @@ depends_on = None
 
 def upgrade():
     """Remove can_read permission on config resource for User and Viewer role"""
+    log = logging.getLogger()
+    handlers = log.handlers[:]
+
     appbuilder = create_app(config={'FAB_UPDATE_PERMS': False}).appbuilder
     roles_to_modify = [role for role in appbuilder.sm.get_all_roles() if role.name in ["User", "Viewer"]]
     can_read_on_config_perm = appbuilder.sm.find_permission_view_menu(
@@ -48,6 +52,8 @@ def upgrade():
         ):
             appbuilder.sm.del_permission_role(role, can_read_on_config_perm)
 
+    log.handlers = handlers
+
 
 def downgrade():
     """Add can_read permission on config resource for User and Viewer role"""