[GitHub] rhtyd opened a new pull request #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR

[GitBox <gi...@apache.org>]

rhtyd opened a new pull request #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR
URL: https://github.com/apache/cloudstack/pull/2635
 
 
   This fixes #2544, ensure that password reset script works in redudant networks.
   
   This ensures that password server runs on the dhcpserver identifier
   IP which is the not the VRRP virtual (10.1.1.1) IP by default but
   the actual ip of the interface. When dhcp client discovery is made,
   the `dhcp-server-identifier` contains the non VIP address that is
   used by password reset script to query guest VM password.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   <!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR -->
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   
   <!-- Fixes: # -->
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   Deployed a guest VM in redundant VR network, with a password enable template (macchinina). Verified on master VRs (and also on switching) that password server runs on the guest nic IP than the VIP and the password script is able to consume the nonVIP address from `dhcp-server-identifier`.
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my environment has passed.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services