You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Stephane Nicoll (JIRA)" <ji...@codehaus.org> on 2008/08/02 16:48:27 UTC
[jira] Closed: (MWAR-133) Filtering issue: wrong replacement of
properties by values from MavenProject object
[ http://jira.codehaus.org/browse/MWAR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephane Nicoll closed MWAR-133.
--------------------------------
Resolution: Fixed
Maven filtering component is handling this scenario properly. Added an it to validate it.
Note that it will work with webResources only. Standard maven resources are still handled by the resources plugin, refer to the linked issue for more information.
> Filtering issue: wrong replacement of properties by values from MavenProject object
> ------------------------------------------------------------------------------------
>
> Key: MWAR-133
> URL: http://jira.codehaus.org/browse/MWAR-133
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Affects Versions: 2.0.2
> Reporter: Thomas Winterschlade
> Assignee: Stephane Nicoll
> Fix For: 2.1-alpha-2
>
> Attachments: MWAR-133-maven-war-plugin.patch
>
>
> When the filter option is enabled in the war plugin, the plugin searches in the affected files for the pattern @...@ and ${...}. If such a pattern is found, the plugin tries to replace the found value. Therefore the ReflectionValueExtractor is used which removes the first part before the dot of the given value; e.g. "node.version" becomes "version". Then the ReflectionValueExtractor tries to find a get- or is-method in the given object (a MavenProject object).
> That means: if the 2nd part of the ${}-property can be found as getter in the MavenProject class, the plugin always uses the maven plugin values.
> The value extractor should only remove the 1st part from the property if the property begins with "project.".
> There is a similar bug report for the resource plugin (date june 2006!!!) which is not yet assigned (title: Filtering ${foo.file} evaluates to in full path to pom.xml).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira