You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:18:04 UTC
[GitHub] [incubator-apisix] membphis commented on a change in pull request #1914: feature: health check supports custom host port.
membphis commented on a change in pull request #1914:
URL: https://github.com/apache/incubator-apisix/pull/1914#discussion_r461296225
##########
File path: apisix/schema_def.lua
##########
@@ -78,6 +78,11 @@ local health_checker = {
timeout = {type = "number", default = 1},
concurrency = {type = "integer", default = 10},
host = host_def,
+ port = {
+ type = "integer",
+ minimum = 1000,
Review comment:
I think the minimum value should be `1`.
##########
File path: apisix/schema_def.lua
##########
@@ -78,6 +78,11 @@ local health_checker = {
timeout = {type = "number", default = 1},
concurrency = {type = "integer", default = 10},
host = host_def,
+ port = {
+ type = "integer",
+ minimum = 1000,
Review comment:
for example the HTTP port `80` is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org