You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@annotator.apache.org by GitBox <gi...@apache.org> on 2022/11/16 10:52:01 UTC

[GitHub] [incubator-annotator-website] PermissionError commented on pull request #31: Address Privacy issues

PermissionError commented on PR #31:
URL: https://github.com/apache/incubator-annotator-website/pull/31#issuecomment-1316797623

   Hi @Treora, thanks for the review. I have removed updates to `content/` so that you can build it separately. Apologies for the mess, I thought this would be a quick fix of just including a couple of new files and modifying a few lines and didn't think the diff would be that large. 
   
   For the inclusion of third party files - I was just think about this when I put them in. My opinion is that it probably doesn't matter, since the project website is not a product to be released outside of the Foundation and distributed to any end users. No "releases" would ever be made. MIT and AL2 are compatible anyhow, so I thought it'd be fine to just include in a non-releasing repository. Do note that I modified `semantic.min.css` to comment out the Google fonts import.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@annotator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org