You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Paul-Blanchaert (via GitHub)" <gi...@apache.org> on 2023/07/07 15:54:56 UTC
[GitHub] [solr] Paul-Blanchaert opened a new pull request, #1764: SOLR-16877: Update BackupManager.java to prevent NPE on empty zk node
Paul-Blanchaert opened a new pull request, #1764:
URL: https://github.com/apache/solr/pull/1764
https://issues.apache.org/jira/browse/SOLR-16877
# Description
Prevent NPE upon trying to write empty zk node to file.
# Solution
ConfigSetService.downloadFileFromConfig is allowed to return null (I reverted my first approach to prevent this return of null). With latest approach, BackupManager.downloadConfigToRepo(...) is updated to detect data==null and replace it by an empty byte[].
# Tests
No tests added. Only functional test executed.
# Checklist
Please review the following and check all that apply:
- [ x ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ x ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ x ] I have developed this patch against the `main` branch.
- [ x ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1764: SOLR-16877: Update BackupManager.java to prevent NPE on empty zk node
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1764:
URL: https://github.com/apache/solr/pull/1764#issuecomment-1629128587
I couldn't push to this branch, because it's an organization fork, not an individual's. But that's ok. I added a changelog entry and pushed to main. Wish this showed as "merged" though. oh well. Thanks for the contribution @Paul-Blanchaert !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman closed pull request #1764: SOLR-16877: Update BackupManager.java to prevent NPE on empty zk node
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman closed pull request #1764: SOLR-16877: Update BackupManager.java to prevent NPE on empty zk node
URL: https://github.com/apache/solr/pull/1764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org