[GitHub] [drill] paul-rogers commented on a change in pull request #2259: DRILL-7931: Rowtype mismatch in DrillReduceAggregatesRule

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #2259:
URL: https://github.com/apache/drill/pull/2259#discussion_r654629939



##########
File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunctions.java
##########
@@ -1239,4 +1239,17 @@ public void testInjectVariablesHashAgg() throws Exception {
       client.resetSession(PlannerSettings.STREAMAGG.getOptionName());
     }
   }
+
+  @Test //DRILL-7931
+  public void testRowTypeMissMatch() throws Exception {
+    testBuilder()
+      .sqlQuery("select col1, stddev(col2) as g1, SUM(col2) as g2 FROM " +
+        "(values ('UA', 3), ('USA', 2), ('UA', 3), ('USA', 5), ('USA', 1), " +
+        "('UA', 9)) t(col1, col2) GROUP BY col1 order by col1")
+      .ordered()
+      .baselineColumns("col1", "g1", "g2")
+      .baselineValues("UA", 3.4641016151377544, 15L)
+      .baselineValues("USA", 2.0816659994661326, 8L)

Review comment:
       Thanks for providing a test! The floating point value is likely unstable: it might differ in the last few digits on different systems. I suggest using a function to round the value to, say, four or five (or whatever) decimals to avoid floating point "noise."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org