You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by xiaosuo <gi...@git.apache.org> on 2017/03/20 06:43:36 UTC

[GitHub] thrift pull request #1216: TNonblockingServer: Fix using uninitialized event...

GitHub user xiaosuo opened a pull request:

    https://github.com/apache/thrift/pull/1216

    TNonblockingServer: Fix using uninitialized event_

    When there are more than one IO threads, and we have failed to notify
    one IO threads, then we have to close the connection. But the event_
    in that connection isn't initialized. We should use setIdle() instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xiaosuo/thrift use-before-init

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1216
    
----
commit 8c00e65d4b5a480efa213389f3e11364eda490ee
Author: Changli Gao <xi...@gmail.com>
Date:   2017-03-20T06:29:07Z

    TNonblockingServer: Fix using uninitialized event_
    
    When there are more than one IO threads, and we have failed to notify
    one IO threads, then we have to close the connection. But the event_
    in that connection isn't initialized. We should use setIdle() instead.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1216: TNonblockingServer: Fix using uninitialized event_

Posted by jeking3 <gi...@git.apache.org>.

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1216
  
    THRIFT-4161


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1216: TNonblockingServer: Fix using uninitialized event...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1216


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1216: TNonblockingServer: Fix using uninitialized event_

Posted by xiaosuo <gi...@git.apache.org>.

Github user xiaosuo commented on the issue:

    https://github.com/apache/thrift/pull/1216
  
    However when closing the connection, we don't check if eventFlags_ is zero.
    
    For a new connection, event_ isn't initialized by the constructor() or init(), and if we fail to pass it to the other IO threads, we will close the connection and use event_ without checking eventFlags_.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1216: TNonblockingServer: Fix using uninitialized event_

Posted by jeking3 <gi...@git.apache.org>.

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1216
  
    Please rebase against upstream/master and force push to kick a new build.  I'd like to see CI pass (or get much closer) before merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---