You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/19 09:12:39 UTC
[GitHub] [camel-quarkus] zbendhiba opened a new pull request #1544: update create new extension guide : add update of test-categories.yaml
zbendhiba opened a new pull request #1544:
URL: https://github.com/apache/camel-quarkus/pull/1544
The compilation fails if extension not present in test-categories.yaml.
I updated the guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1544: update create new extension guide : add update of test-categories.yaml
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1544:
URL: https://github.com/apache/camel-quarkus/pull/1544#issuecomment-676040471
Thanks @zbendhiba !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #1544: update create new extension guide : add update of test-categories.yaml
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1544:
URL: https://github.com/apache/camel-quarkus/pull/1544
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a change in pull request #1544: update create new extension guide : add update of test-categories.yaml
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #1544:
URL: https://github.com/apache/camel-quarkus/pull/1544#discussion_r472892485
##########
File path: docs/modules/ROOT/pages/contributor-guide/create-new-extension.adoc
##########
@@ -36,10 +36,12 @@ The above sequence of commands does the following:
* It creates a basic `FooAbcProcessor` class in the deployment module.
* It also creates a stub of an integration test module under `integration-tests/foo-abc`.
+
+6. Add the extension name in the rigth category in `tooling/scripts/test-categories.yaml` file.
Review comment:
@jamesnetherton thanks. I made the changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1544: update create new extension guide : add update of test-categories.yaml
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1544:
URL: https://github.com/apache/camel-quarkus/pull/1544#discussion_r472884692
##########
File path: docs/modules/ROOT/pages/contributor-guide/create-new-extension.adoc
##########
@@ -36,10 +36,12 @@ The above sequence of commands does the following:
* It creates a basic `FooAbcProcessor` class in the deployment module.
* It also creates a stub of an integration test module under `integration-tests/foo-abc`.
+
+6. Add the extension name in the rigth category in `tooling/scripts/test-categories.yaml` file.
Review comment:
```suggestion
6. Add the extension name to the right category in `tooling/scripts/test-categories.yaml` file.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org