You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/04 18:42:27 UTC

[GitHub] [airflow] potiuk opened a new pull request #14082: Corrections in docs and tools after releasing provider RCs

potiuk opened a new pull request #14082:
URL: https://github.com/apache/airflow/pull/14082

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

kaxil commented on a change in pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#discussion_r570948001



##########
File path: dev/README_RELEASE_PROVIDER_PACKAGES.md
##########
@@ -283,21 +283,37 @@ cd "${AIRFLOW_REPO_ROOT}"
 
 - Copy the documentation to the ``airflow-site`` repository
 
+**NOTE** In oder to run the publish_doc
+
+All providers:
+
 ```shell script
 ./docs/publish_docs.py \
     --package-filter apache-airflow-providers \
-    --package-filter apache-airflow-providers-telegram \
+    --package-filter 'apache-airflow-providers-*'
 
 cd "${AIRFLOW_SITE_DIRECTORY}"
 ```
 
+If you have released just a few providers:
+
+```shell script
+./docs/publish_docs.py \
+    --package-filter apache-airflow-providers \
+  --package-filter 'apache-airflow-providers-PACKAGE1' \
+  --package-filter 'apache-airflow-providers-PACKAGE2' \

Review comment:
       nit
   ```suggestion
   ./docs/publish_docs.py \
       --package-filter apache-airflow-providers \
       --package-filter 'apache-airflow-providers-PACKAGE1' \
       --package-filter 'apache-airflow-providers-PACKAGE2' \
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#discussion_r570905608



##########
File path: dev/README_RELEASE_PROVIDER_PACKAGES.md
##########
@@ -278,26 +278,42 @@ cd "${AIRFLOW_REPO_ROOT}"
 - Now you can preview the documentation.
 
 ```shell script
-./docs/start_doc_server.sh
+./docs/start_doc_server1.sh

Review comment:
       ```suggestion
   ./docs/start_doc_server.sh
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#issuecomment-773524171






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#discussion_r570833765



##########
File path: dev/README_RELEASE_PROVIDER_PACKAGES.md
##########
@@ -278,26 +278,42 @@ cd "${AIRFLOW_REPO_ROOT}"
 - Now you can preview the documentation.
 
 ```shell script
-./docs/start_doc_server.sh
+./docs/start_doc_server1.sh

Review comment:
       ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#issuecomment-773711726


   [The Workflow run](https://github.com/apache/airflow/actions/runs/538969804) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#issuecomment-773529670


   Sure. no hurry with that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #14082:
URL: https://github.com/apache/airflow/pull/14082


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#issuecomment-773711726


   [The Workflow run](https://github.com/apache/airflow/actions/runs/538969804) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#issuecomment-773524171


   Round of updates after releasing providers RC1 regular, backports and the documentation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#discussion_r570833883



##########
File path: dev/README_RELEASE_PROVIDER_PACKAGES.md
##########
@@ -321,7 +337,7 @@ EOF
 cat <<EOF
 Hey all,
 
-I have cut Airflow Providers. This email is calling a vote on the release,
+I have just cut the new wave f Airflow Providers packages. This email is calling a vote on the release,

Review comment:
       ```suggestion
   I have just cut the new wave Airflow Providers packages. This email is calling a vote on the release,
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#discussion_r570833765



##########
File path: dev/README_RELEASE_PROVIDER_PACKAGES.md
##########
@@ -278,26 +278,42 @@ cd "${AIRFLOW_REPO_ROOT}"
 - Now you can preview the documentation.
 
 ```shell script
-./docs/start_doc_server.sh
+./docs/start_doc_server1.sh

Review comment:
       ?

##########
File path: dev/README_RELEASE_PROVIDER_PACKAGES.md
##########
@@ -321,7 +337,7 @@ EOF
 cat <<EOF
 Hey all,
 
-I have cut Airflow Providers. This email is calling a vote on the release,
+I have just cut the new wave f Airflow Providers packages. This email is calling a vote on the release,

Review comment:
       ```suggestion
   I have just cut the new wave Airflow Providers packages. This email is calling a vote on the release,
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#issuecomment-774032829


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #14082: Corrections in docs and tools after releasing provider RCs

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #14082:
URL: https://github.com/apache/airflow/pull/14082#discussion_r570905087



##########
File path: dev/README_RELEASE_PROVIDER_PACKAGES.md
##########
@@ -278,26 +278,42 @@ cd "${AIRFLOW_REPO_ROOT}"
 - Now you can preview the documentation.
 
 ```shell script
-./docs/start_doc_server.sh
+./docs/start_doc_server1.sh

Review comment:
       No idea :) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org