You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/12 12:19:00 UTC
[jira] [Commented] (FLINK-7166) generated avro sources not cleaned
up or re-created after changes
[ https://issues.apache.org/jira/browse/FLINK-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083889#comment-16083889 ]
ASF GitHub Bot commented on FLINK-7166:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4309
[FLINK-7166][avro] cleanup generated test classes in the cleanup phase
Maven neither cleaned up generated avro classes used by tests nor did it replace
them with new ones after the avro dependency change causing troubles to build
the project. Although the target directory inside `src` is unusual, we keep it
for now but at least delete these files in the cleanup stage so that a
`mvn clean install` always works.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7166
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4309
----
commit d6aec8f4d9666bdf912c768190033cf521b40b0a
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-07-12T12:15:24Z
[FLINK-7166][avro] cleanup generated test classes in the cleanup phase
Maven neither cleaned up generated avro classes used by tests nor did it replace
them with new ones after the avro dependency change causing troubles to build
the project. Although the target directory inside `src` is unusual, we keep it
for now but at least delete these files in the cleanup stage so that a
`mvn clean install` always works.
----
> generated avro sources not cleaned up or re-created after changes
> -----------------------------------------------------------------
>
> Key: FLINK-7166
> URL: https://issues.apache.org/jira/browse/FLINK-7166
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> Since the AVRO upgrade to 1.8.2, I could compile the flink-avro module any more with a failure like this in {{mvn clean install -DskipTests -pl flink-connectors/flink-avro}}:
> {code}
> Compilation failure
> [ERROR] flink-connectors/flink-avro/src/test/java/org/apache/flink/api/io/avro/generated/Fixed16.java:[10,8] org.apache.flink.api.io.avro.generated.Fixed16 is not abstract and does not override abstract method readExternal(java.io.ObjectInput) in org.apache.avro.specific.SpecificFixed
> {code}
> This was caused by maven both not cleaning up the generated sources and also not overwriting them with new ones itself. Only a manual {{rm -rf flink-connectors/flink-avro/src/test/java/org/apache/flink/api/io/avro/generated}} solved the issue.
> The cause for this, though, is that the avro files are generated under the {{src}} directory, not {{target/generated-test-sources}} as they should be. Either the generated sources should be cleaned up as well, or the generated files should be moved to this directory which is a more invasive change due to some hacks with respect to these files.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)